File xsa237-5.patch of Package xen.5852

Overview Repositories Revisions Requests Users Attributes Meta

File xsa237-5.patch of Package xen.5852

From: Jan Beulich <jbeulich@suse.com>
Subject: x86/FLASK: fix unmap-domain-IRQ XSM hook

The caller and the FLASK implementation of xsm_unmap_domain_irq()
disagreed about what the "data" argument points to in the MSI case:
Change both sides to pass/take a PCI device.

This is part of XSA-237.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

Index: xen-4.7.3-testing/xen/arch/x86/irq.c
===================================================================
--- xen-4.7.3-testing.orig/xen/arch/x86/irq.c
+++ xen-4.7.3-testing/xen/arch/x86/irq.c
@@ -2146,7 +2146,8 @@ int unmap_domain_pirq(struct domain *d,
         nr = msi_desc->msi.nvec;
     }
 
-    ret = xsm_unmap_domain_irq(XSM_HOOK, d, irq, msi_desc);
+    ret = xsm_unmap_domain_irq(XSM_HOOK, d, irq,
+                               msi_desc ? msi_desc->dev : NULL);
     if ( ret )
         goto done;
 
Index: xen-4.7.3-testing/xen/xsm/flask/hooks.c
===================================================================
--- xen-4.7.3-testing.orig/xen/xsm/flask/hooks.c
+++ xen-4.7.3-testing/xen/xsm/flask/hooks.c
@@ -911,8 +911,8 @@ static int flask_unmap_domain_msi (struc
                                    u32 *sid, struct avc_audit_data *ad)
 {
 #ifdef CONFIG_HAS_PCI
-    struct msi_info *msi = data;
-    u32 machine_bdf = (msi->seg << 16) | (msi->bus << 8) | msi->devfn;
+    const struct pci_dev *pdev = data;
+    u32 machine_bdf = (pdev->seg << 16) | (pdev->bus << 8) | pdev->devfn;
 
     AVC_AUDIT_DATA_INIT(ad, DEV);
     ad->device = machine_bdf;

Places

File xsa237-5.patch of Package xen.5852

Places