File bsc#1171372-0002-Fix-libstonithd-action-paramet... of Package pacemaker.22685

Overview Repositories Revisions Requests Users Attributes Meta

File bsc#1171372-0002-Fix-libstonithd-action-parameter-of-RHCS-style-fence-1.1.patch of Package pacemaker.22685

From 90faf68a27ab352f1030f120b79ea9aabfbab883 Mon Sep 17 00:00:00 2001
From: "Gao,Yan" <ygao@suse.com>
Date: Wed, 15 Apr 2020 19:39:29 +0200
Subject: [PATCH 2/2] Fix: libstonithd: `action` parameter of RHCS-style
 fence-agents is shown as non-required in the metadata

The parameter `action` of RHCS-style fence-agents shouldn't usually be
specified in fencing resource configuration, although it'd be properly
remapped anyways with 9c0c3d60b4.

With this commit, the parameter `action` of RHCS-style fence-agents is
fudged to be shown as `required="0"` in the metadata output by
`stonith_admin --metadata` or `crm_resource --show-metadata`. So that
users know they don't have to configure it. Pacemaker handles and passes
the parameter to the agent when executing it.
---
 lib/fencing/st_rhcs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/fencing/st_rhcs.c b/lib/fencing/st_rhcs.c
index c819d6301..ab3fb418f 100644
--- a/lib/fencing/st_rhcs.c
+++ b/lib/fencing/st_rhcs.c
@@ -156,7 +156,8 @@ stonith__rhcs_metadata(const char *agent, int timeout, char **output)
     }
     freeXpathObject(xpathObj);
 
-    // Fudge metadata so port isn't required in config (pacemaker adds it)
+    // Fudge metadata so parameters are not required in config (pacemaker adds them)
+    stonith_rhcs_parameter_not_required(xml, "action");
     stonith_rhcs_parameter_not_required(xml, "port");
 
     buffer = dump_xml_formatted_with_text(xml);
-- 
2.26.1

Places

File bsc#1171372-0002-Fix-libstonithd-action-parameter-of-RHCS-style-fence-1.1.patch of Package pacemaker.22685

Places