Sign Up
Log In
Log In
or
Sign Up
Places
All Projects
Status Monitor
Collapse sidebar
SUSE:SLE-12-SP5:GA
xen.3242
xsa178-0011-libxl-Rename-libxl__device_-nic-cha...
Overview
Repositories
Revisions
Requests
Users
Attributes
Meta
File xsa178-0011-libxl-Rename-libxl__device_-nic-channel-_from_xs_be-.patch of Package xen.3242
References: bsc#979670 CVE-2016-4963 XSA-178 From 47ac7a8558135553ebb190fbfef3438ce16c3581 Mon Sep 17 00:00:00 2001 From: Ian Jackson <ian.jackson@eu.citrix.com> Date: Wed, 4 May 2016 16:18:36 +0100 Subject: [PATCH 11/21] libxl: Rename libxl__device_{nic,channel}_from_xs_be to _from_xenstore We are going to change these functions to expect, and be passed, a /libxl path. So it is wrong that they are called _from_xs_be. Neither function reads anything which isn't found in both places, so we can and will change the call sites later. The only remaining function in libxl called *_from_xs_be relates to PCI devices, for which the backend domain is hardcoded to 0 throughout the libxl_pci.c. No functional change. This is part of XSA-178. Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com> Reviewed-by: Wei Liu <wei.liu2@citrix.com> --- tools/libxl/libxl.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) Index: xen-4.5.3-testing/tools/libxl/libxl.c =================================================================== --- xen-4.5.3-testing.orig/tools/libxl/libxl.c +++ xen-4.5.3-testing/tools/libxl/libxl.c @@ -3511,7 +3511,7 @@ out: return; } -static int libxl__device_nic_from_xs_be(libxl__gc *gc, +static int libxl__device_nic_from_xenstore(libxl__gc *gc, const char *be_path, libxl_device_nic *nic) { @@ -3574,7 +3574,7 @@ int libxl_devid_to_device_nic(libxl_ctx if (!path) goto out; - rc = libxl__device_nic_from_xs_be(gc, path, nic); + rc = libxl__device_nic_from_xenstore(gc, path, nic); if (rc) goto out; rc = 0; @@ -3609,7 +3609,7 @@ static int libxl__append_nic_list_of_typ for (; pnic < pnic_end; pnic++, dir++) { const char *p; p = libxl__sprintf(gc, "%s/%s", be_path, *dir); - rc = libxl__device_nic_from_xs_be(gc, p, pnic); + rc = libxl__device_nic_from_xenstore(gc, p, pnic); if (rc) goto out; pnic->backend_domid = 0; } @@ -3859,7 +3859,7 @@ int libxl__init_console_from_channel(lib return 0; } -static int libxl__device_channel_from_xs_be(libxl__gc *gc, +static int libxl__device_channel_from_xenstore(libxl__gc *gc, const char *be_path, libxl_device_channel *channel) { @@ -3868,7 +3868,7 @@ static int libxl__device_channel_from_xs libxl_device_channel_init(channel); - /* READ_BACKEND is from libxl__device_nic_from_xs_be above */ + /* READ_BACKEND is from libxl__device_nic_from_xenstore above */ channel->name = READ_BACKEND(NOGC, "name"); tmp = READ_BACKEND(gc, "connection"); if (!strcmp(tmp, "pty")) { @@ -3923,7 +3923,7 @@ static int libxl__append_channel_list(li } *channels = tmp; next = *channels + *nchannels + devid; - rc = libxl__device_channel_from_xs_be(gc, be_path, next); + rc = libxl__device_channel_from_xenstore(gc, be_path, next); if (rc) goto out; next->devid = devid; devid++;
Locations
Projects
Search
Status Monitor
Help
OpenBuildService.org
Documentation
API Documentation
Code of Conduct
Contact
Support
@OBShq
Terms
openSUSE Build Service is sponsored by
The Open Build Service is an
openSUSE project
.
Sign Up
Log In
Places
Places
All Projects
Status Monitor