File avrcp-Fix-not-checking-if-params_len-match-numb... of Package bluez

Overview Repositories Revisions Requests Users Attributes Meta

File avrcp-Fix-not-checking-if-params_len-match-number-of.patch of Package bluez (Revision b80f8b12f9fd1fd5ae6f6166e3e22a1a)

Currently displaying revision b80f8b12f9fd1fd5ae6f6166e3e22a1a , Show latest

From e2b0f0d8d63e1223bb714a9efb37e2257818268b Mon Sep 17 00:00:00 2001
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Date: Thu, 29 Apr 2021 18:18:57 -0700
Subject: [PATCH] avrcp: Fix not checking if params_len match number of
 received bytes

This makes sure the number of bytes in the params_len matches the
remaining bytes received so the code don't end up accessing invalid
memory.
---
 profiles/audio/avrcp.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Index: bluez-5.13/profiles/audio/avrcp.c
===================================================================
--- bluez-5.13.orig/profiles/audio/avrcp.c
+++ bluez-5.13/profiles/audio/avrcp.c
@@ -1658,6 +1658,14 @@ static size_t handle_vendordep_pdu(struc
 		goto err_metadata;
 	}
 
+	operands += sizeof(*pdu);
+	operand_count -= sizeof(*pdu);
+
+	if (pdu->params_len != operand_count) {
+		DBG("AVRCP PDU parameters length don't match");
+		pdu->params_len = operand_count;
+	}
+
 	for (handler = session->control_handlers; handler->pdu_id; handler++) {
 		if (handler->pdu_id == pdu->pdu_id)
 			break;

Places

File avrcp-Fix-not-checking-if-params_len-match-number-of.patch of Package bluez (Revision b80f8b12f9fd1fd5ae6f6166e3e22a1a)

Places