File r1892-Do-not-disable-PODOFO_RAISE_LOGIC_IF-for-... of Package podofo.34526

Overview Repositories Revisions Requests Users Attributes Meta

File r1892-Do-not-disable-PODOFO_RAISE_LOGIC_IF-for-Release-builds-_also-fixes-CVE-2017-6845_.patch of Package podofo.34526

------------------------------------------------------------------------
r1892 | mc-zyx | 2018-02-22 10:23:19 +0100 (jue, 22 feb 2018) | 2 lines

Do not disable PODOFO_RAISE_LOGIC_IF for Release builds (also fixes CVE-2017-6845)

Index: src/base/PdfError.h
===================================================================
--- src/base/PdfError.h	(revision 1891)
+++ src/base/PdfError.h	(revision 1892)
@@ -169,18 +169,8 @@
  *
  *  Evaluate `x' as a binary predicate and if it is true, raise a logic error with the
  *  info string `y' .
- *
- *  This macro will be undefined when NDEBUG is set, so it's compiled out for release
- *  builds. Use it for expensive or extremely frequent sanity checking.
- *
- *  We define it then UNDEF it to help out doxygen.
  */
-#ifndef NDEBUG
-    // Woo for double-negatives. We define PODOFO_RAISE_LOGIC_IF unless we've been told not to by NDEBUG.
-    #define PODOFO_RAISE_LOGIC_IF( x, y ) { if (x) throw ::PoDoFo::PdfError( ePdfError_InternalLogic, __FILE__, __LINE__, y ); };
-#else
-    #define PODOFO_RAISE_LOGIC_IF( x, y ) {};
-#endif
+#define PODOFO_RAISE_LOGIC_IF( x, y ) { if (x) throw ::PoDoFo::PdfError( ePdfError_InternalLogic, __FILE__, __LINE__, y ); };
 
 class PODOFO_API PdfErrorInfo {
  public:

------------------------------------------------------------------------

Places

File r1892-Do-not-disable-PODOFO_RAISE_LOGIC_IF-for-Release-builds-_also-fixes-CVE-2017-6845_.patch of Package podofo.34526

Places