File 0001-unit-suppress-unnecessary-cgroup-empty-che... of Package systemd

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-unit-suppress-unnecessary-cgroup-empty-check.patch of Package systemd (Revision d6ed623c2f7c97a87bb3622504268b5d)

Currently displaying revision d6ed623c2f7c97a87bb3622504268b5d , Show latest

Based on 957c3cf97cd0063a3b78aa068d5351ae3b1b0c0c Mon Sep 17 00:00:00 2001
From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 1 Sep 2015 16:45:34 +0200
Subject: [PATCH] unit: suppress unnecessary cgroup empty check

Rework the "service is good" check, to only check the cgroup state if we
really need to instead of always.

This allows us to suppress going to the cgroupfs for an empty check for
the majority of services.

No functional change.
---
 src/core/service.c | 27 +++++++++++++++++++++------
 1 file changed, 21 insertions(+), 6 deletions(-)

--- src/core/service.c
+++ src/core/service.c	2015-09-03 13:28:33.093539255 +0000
@@ -2117,18 +2117,33 @@ fail:
         service_enter_signal(s, SERVICE_STOP_SIGTERM, SERVICE_FAILURE_RESOURCES);
 }
 
+static bool service_good(Service *s) {
+        int main_pid_ok;
+        assert(s);
+
+        if (s->type == SERVICE_DBUS && !s->bus_name_good)
+                return false;
+
+        main_pid_ok = main_pid_good(s);
+        if (main_pid_ok > 0) /* It's alive */
+                return true;
+        if (main_pid_ok == 0) /* It's dead */
+                return false;
+
+        /* OK, we don't know anything about the main PID, maybe
+         * because there is none. Let's check the control group
+         * instead. */
+
+        return cgroup_good(s) != 0;
+}
+
 static void service_enter_running(Service *s, ServiceResult f) {
-        int main_pid_ok, cgroup_ok;
         assert(s);
 
         if (f != SERVICE_SUCCESS)
                 s->result = f;
 
-        main_pid_ok = main_pid_good(s);
-        cgroup_ok = cgroup_good(s);
-
-        if ((main_pid_ok > 0 || (main_pid_ok < 0 && cgroup_ok != 0)) &&
-            (s->bus_name_good || s->type != SERVICE_DBUS)) {
+        if (service_good(s)) {
 #ifdef HAVE_SYSV_COMPAT
                 if (s->sysv_enabled && !s->pid_file && s->sysv_remain_after_exit_heuristic)
                         s->remain_after_exit = false;

Places

File 0001-unit-suppress-unnecessary-cgroup-empty-check.patch of Package systemd (Revision d6ed623c2f7c97a87bb3622504268b5d)

Places