File 598c3706-cpufreq-only-stop-ondemand-governor-if... of Package xen

Overview Repositories Revisions Requests Users Attributes Meta

File 598c3706-cpufreq-only-stop-ondemand-governor-if-started.patch of Package xen

# Commit e7ec6f5f32cd2d0f723083cde3d7761c4e675f2c
# Date 2017-08-10 12:35:50 +0200
# Author Christopher Clark <christopher.clark6@baesystems.com>
# Committer Jan Beulich <jbeulich@suse.com>
cpufreq: only stop ondemand governor if already started

On CPUFREQ_GOV_STOP in cpufreq_governor_dbs, shortcut to
return success if the governor is already stopped.

Avoid executing dbs_timer_exit, to prevent tripping an assertion
within a call to kill_timer on a timer that has not been prepared
with init_timer, if the CPUFREQ_GOV_START case has not
run beforehand.

kill_timer validates timer state:
 * itself, via BUG_ON(this_cpu(timers).running == timer);
 * within active_timer, ASSERTing timer->status is within bounds;
 * within list_del, which ASSERTs timer inactive list membership.

Patch is synonymous to an OpenXT patch produced at Citrix prior to
June 2014.

Signed-off-by: Christopher Clark <christopher.clark6@baesystems.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/drivers/cpufreq/cpufreq_ondemand.c
+++ b/xen/drivers/cpufreq/cpufreq_ondemand.c
@@ -273,6 +273,10 @@ int cpufreq_governor_dbs(struct cpufreq_
         break;
 
     case CPUFREQ_GOV_STOP:
+        if ( !this_dbs_info->enable )
+            /* Already not enabled */
+            break;
+
         dbs_timer_exit(this_dbs_info);
         dbs_enable--;

Places

File 598c3706-cpufreq-only-stop-ondemand-governor-if-started.patch of Package xen

Places