File CVE-2024-39329.patch of Package python-Django.34904

Overview Repositories Revisions Requests Users Attributes Meta

File CVE-2024-39329.patch of Package python-Django.34904

From 360797b77244960edfe91a24f4c364b72fea4f66 Mon Sep 17 00:00:00 2001
From: nkrapp <nico.krapp@suse.com>
Date: Fri, 26 Jul 2024 16:15:54 +0200
Subject: [PATCH] Fixed CVE-2024-39329 -- Standarized timing of 
 verify_password() when checking unusuable passwords.

---
 django/contrib/auth/hashers.py   | 16 +++++++++++++---
 tests/auth_tests/test_hashers.py | 22 ++++++++++++++++++++++
 2 files changed, 35 insertions(+), 3 deletions(-)

diff --git a/django/contrib/auth/hashers.py b/django/contrib/auth/hashers.py
index c14ece20fb..956798193f 100644
--- a/django/contrib/auth/hashers.py
+++ b/django/contrib/auth/hashers.py
@@ -39,11 +39,21 @@ def check_password(password, encoded, setter=None, preferred='default'):
     If setter is specified, it'll be called when you need to
     regenerate the password.
     """
-    if password is None or not is_password_usable(encoded):
-        return False
+    fake_runtime = password is None or not is_password_usable(encoded)
 
     preferred = get_hasher(preferred)
-    hasher = identify_hasher(encoded)
+    try:
+        hasher = identify_hasher(encoded)
+    except ValueError:
+        # encoded is gibberish or uses a hasher that's no longer installed.
+        fake_runtime = True
+    
+    if fake_runtime:
+        # Run the default password hasher once to reduce the timing difference
+        # between an existing user with an unusable password and a nonexistent
+        # user or missing hasher (similar to #20760).
+        make_password(get_random_string(UNUSABLE_PASSWORD_SUFFIX_LENGTH))
+        return False
 
     hasher_changed = hasher.algorithm != preferred.algorithm
     must_update = hasher_changed or preferred.must_update(encoded)
diff --git a/tests/auth_tests/test_hashers.py b/tests/auth_tests/test_hashers.py
index cf12fd4168..061bfb8b59 100644
--- a/tests/auth_tests/test_hashers.py
+++ b/tests/auth_tests/test_hashers.py
@@ -440,6 +440,28 @@ class TestUtilsHashPass(SimpleTestCase):
         with self.assertRaisesMessage(ValueError, msg):
             PlainHasher()._load_library()
 
+    def test_check_password_calls_make_password_to_fake_runtime(self):
+        hasher = get_hasher("default")
+        cases = [
+            (None, None, None),  # no plain text password provided
+            ("foo", make_password(password=None), None),  # unusable encoded
+            ("letmein", make_password(password="letmein"), ValueError),  # valid encoded
+        ]
+        for password, encoded, hasher_side_effect in cases:
+            with self.subTest(encoded=encoded):
+                with mock.patch("django.contrib.auth.hashers.identify_hasher", side_effect=hasher_side_effect) as mock_identify_hasher:
+                    with mock.patch("django.contrib.auth.hashers.make_password") as mock_make_password:
+                        with mock.patch("django.contrib.auth.hashers.get_random_string", side_effect=lambda size: "x" * size):
+                            with mock.patch.object(hasher, "verify"):
+                                # Ensure make_password is called to standardize timing.
+                                check_password(password, encoded)
+                                self.assertEqual(hasher.verify.call_count, 0)
+                                self.assertEqual(mock_identify_hasher.mock_calls, [mock.call(encoded)])
+                                self.assertEqual(
+                                    mock_make_password.mock_calls,
+                                    [mock.call("x" * UNUSABLE_PASSWORD_SUFFIX_LENGTH)],
+                                )
+
 
 @skipUnless(argon2, "argon2-cffi not installed")
 @override_settings(PASSWORD_HASHERS=PASSWORD_HASHERS)
-- 
2.45.2

Places

File CVE-2024-39329.patch of Package python-Django.34904

Places