File 0136-s390x-pci-Always-delete-and-free-th.patch of Package qemu-linux-user

Overview Repositories Revisions Requests Users Attributes Meta

File 0136-s390x-pci-Always-delete-and-free-th.patch of Package qemu-linux-user (Revision be33573487a5378b95f925c45d0312ca)

Currently displaying revision be33573487a5378b95f925c45d0312ca , Show latest

From: David Hildenbrand <david@redhat.com>
Date: Mon, 14 Jan 2019 11:31:07 +0100
Subject: s390x/pci: Always delete and free the release_timer

Include-If: %if 0%{?suse_version} == 1315
Git-commit: d648a3e62d5e726526f9df283341999792f4fbf9
References: bsc#1179725

We should always get rid of it. I don't see a reason to keep the timer
alive if the devices are going away. This looks like a memory leak.

(hmp) device_add virtio-mouse-pci,id=test
(hmp) device_del test
-> guest notified, timer pending.
-> guest does not react for some reason (e.g. crash)
-> s390_pcihost_timer_cb(). Timer not pending anymore. qmp_unplug().

-> Device deleted. Timer expired (not pending) but not freed.

Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190114103110.10909-4-david@redhat.com>
Reviewed-by: Collin Walling <walling@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Cho, Yu-Chen <acho@suse.com>
---
 hw/s390x/s390-pci-bus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
index a98ee6e5aff2c6a0ec52cde41cdc..b87ba6320fcfb646e239d1fbebf9 100644
--- a/hw/s390x/s390-pci-bus.c
+++ b/hw/s390x/s390-pci-bus.c
@@ -982,7 +982,7 @@ static void s390_pcihost_unplug(HotplugHandler *hotplug_dev, DeviceState *dev,
         return;
     }
 
-    if (pbdev->release_timer && timer_pending(pbdev->release_timer)) {
+    if (pbdev->release_timer) {
         timer_del(pbdev->release_timer);
         timer_free(pbdev->release_timer);
         pbdev->release_timer = NULL;

Places

File 0136-s390x-pci-Always-delete-and-free-th.patch of Package qemu-linux-user (Revision be33573487a5378b95f925c45d0312ca)

Places