File 5d53ed45-pygrub-Failing-to-set-value-to-0-in-Gr... of Package xen

Overview Repositories Revisions Requests Users Attributes Meta

File 5d53ed45-pygrub-Failing-to-set-value-to-0-in-Grub2ConfigFile.patch of Package xen (Revision e73a69a933e5a960b90028f6207a788d)

Currently displaying revision e73a69a933e5a960b90028f6207a788d , Show latest

Subject: tools/pygrub: Failing to set value to 0 in Grub2ConfigFile
From: Michael Young m.a.young@durham.ac.uk Tue Aug 13 21:15:02 2019 +0100
Date: Wed Aug 14 12:15:17 2019 +0100:
Git: e5368348d33be8cc476433489e362834a47e4dcf

In Grub2ConfigFile the code to handle ${saved_entry} and ${next_entry}
sets arg = "0" but this now does nothing following c/s d1b93ea2615bd
"tools/pygrub: Make pygrub understand default entry in string format"
which replaced arg.strip() with arg_strip in the following line.  This
patch restores the previous behaviour.

Signed-off-by: Michael Young <m.a.young@durham.ac.uk>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

diff --git a/tools/pygrub/src/GrubConf.py b/tools/pygrub/src/GrubConf.py
index 594139bac7..73f1bbed2f 100644
--- a/tools/pygrub/src/GrubConf.py
+++ b/tools/pygrub/src/GrubConf.py
@@ -433,7 +433,7 @@ class Grub2ConfigFile(_GrubConfigFile):
                     arg_strip = arg.strip()
                     if arg_strip == "${saved_entry}" or arg_strip == "${next_entry}":
                         logging.warning("grub2's saved_entry/next_entry not supported")
-                        arg = "0"
+                        arg_strip = "0"
                     setattr(self, self.commands[com], arg_strip)
                 else:
                     logging.info("Ignored directive %s" %(com,))

Places

File 5d53ed45-pygrub-Failing-to-set-value-to-0-in-Grub2ConfigFile.patch of Package xen (Revision e73a69a933e5a960b90028f6207a788d)

Places