File 5e95af5e-xen-gnttab-Fix-error-path-in-map_grant... of Package xen

Overview Repositories Revisions Requests Users Attributes Meta

File 5e95af5e-xen-gnttab-Fix-error-path-in-map_grant_ref.patch of Package xen (Revision 3a513a1c247a1fd4ac85ccdcb610d485)

Currently displaying revision 3a513a1c247a1fd4ac85ccdcb610d485 , Show latest

Subject: xen/gnttab: Fix error path in map_grant_ref()
From: Ross Lagerwall ross.lagerwall@citrix.com Tue Apr 14 14:41:02 2020 +0200
Date: Tue Apr 14 14:41:02 2020 +0200:
Git: da0c66c8f48042a0186799014af69db0303b1da5

Part of XSA-295 (c/s 863e74eb2cffb) inadvertently re-positioned the brackets,
changing the logic.  If the _set_status() call fails, the grant_map hypercall
would fail with a status of 1 (rc != GNTST_okay) instead of the expected
negative GNTST_* error.

This error path can be taken due to bad guest state, and causes net/blk-back
in Linux to crash.

This is XSA-316.

Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Julien Grall <jgrall@amazon.com>

diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
index 9fd6e60416..4b5344dc21 100644
--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -1015,7 +1015,7 @@ map_grant_ref(
     {
         if ( (rc = _set_status(shah, status, rd, rgt->gt_version, act,
                                op->flags & GNTMAP_readonly, 1,
-                               ld->domain_id) != GNTST_okay) )
+                               ld->domain_id)) != GNTST_okay )
             goto act_release_out;
 
         if ( !act->pin )

Places

File 5e95af5e-xen-gnttab-Fix-error-path-in-map_grant_ref.patch of Package xen (Revision 3a513a1c247a1fd4ac85ccdcb610d485)

Places