File 624ebcef-VT-d-dont-needlessly-look-up-DID.patch of Package xen

Overview Repositories Revisions Requests Users Attributes Meta

File 624ebcef-VT-d-dont-needlessly-look-up-DID.patch of Package xen (Revision 2ec989e1b40bf5aaa2a921cea343167a)

Currently displaying revision 2ec989e1b40bf5aaa2a921cea343167a , Show latest

# Commit 445ab9852d69d8957467f0036098ebec75fec092
# Date 2022-04-07 12:29:03 +0200
# Author Jan Beulich <jbeulich@suse.com>
# Committer Jan Beulich <jbeulich@suse.com>
VT-d: don't needlessly look up DID

If get_iommu_domid() in domain_context_unmap_one() fails, we better
wouldn't clear the context entry in the first place, as we're then unable
to issue the corresponding flush. However, we have no need to look up the
DID in the first place: What needs flushing is very specifically the DID
that was in the context entry before our clearing of it.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -1862,18 +1862,12 @@ int domain_context_unmap_one(
         return 0;
     }
 
+    iommu_domid = context_domain_id(*context);
+
     context_clear_present(*context);
     context_clear_entry(*context);
     iommu_sync_cache(context, sizeof(struct context_entry));
 
-    iommu_domid = get_iommu_did(domid, iommu, !domain->is_dying);
-    if ( iommu_domid == -1 )
-    {
-        spin_unlock(&iommu->lock);
-        unmap_vtd_domain_page(context_entries);
-        return -EINVAL;
-    }
-
     rc = iommu_flush_context_device(iommu, iommu_domid,
                                     PCI_BDF2(bus, devfn),
                                     DMA_CCMD_MASK_NOBIT, 0);

Places

File 624ebcef-VT-d-dont-needlessly-look-up-DID.patch of Package xen (Revision 2ec989e1b40bf5aaa2a921cea343167a)

Places