File 0238-Partially-revert-build-no-pie-is-no.patch of Package qemu-testsuite

Overview Repositories Revisions Requests Users Attributes Meta

File 0238-Partially-revert-build-no-pie-is-no.patch of Package qemu-testsuite

From: Jessica Clarke <jrtc27@jrtc27.com>
Date: Thu, 5 Aug 2021 20:25:45 +0100
Subject: Partially revert "build: -no-pie is no functional linker flag"

Git-commit: ffd205ef2901bd65fcfbd09a98c0ff7cfcec5e4d
References: bsc#1192463

This partially reverts commit bbd2d5a8120771ec59b86a80a1f51884e0a26e53.

This commit was misguided and broke using --disable-pie on any distro
that enables PIE by default in their compiler driver, including Debian
and its derivatives. Whilst -no-pie is not a linker flag, it is a
compiler driver flag that ensures -pie is not automatically passed by it
to the linker. Without it, all compile_prog checks will fail as any code
built with the explicit -fno-pie will fail to link with the implicit
default -pie due to trying to use position-dependent relocations. The
only bug that needed fixing was LDFLAGS_NOPIE being used as a flag for
the linker itself in pc-bios/optionrom/Makefile.

Note this does not reinstate exporting LDFLAGS_NOPIE, as it is unused,
since the only previous use was the one that should not have existed. I
have also updated the comment for the -fno-pie and -no-pie checks to
reflect what they're actually needed for.

Fixes: bbd2d5a8120771ec59b86a80a1f51884e0a26e53
Cc: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Jessica Clarke <jrtc27@jrtc27.com>
Message-Id: <20210805192545.38279-1-jrtc27@jrtc27.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Liang Yan <lyan@suse.com>
---
 configure | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configure b/configure
index 690dc02b97d91e27dcffd231b067..b5ac0ee13231e4aca656b49e09e9 100755
--- a/configure
+++ b/configure
@@ -1992,6 +1992,7 @@ EOF
 
   if compile_prog "-Werror -fno-pie" "-nopie"; then
     CFLAGS_NOPIE="-fno-pie"
+    LDFLAGS_NOPIE="-no-pie"
   fi
 fi

Places

File 0238-Partially-revert-build-no-pie-is-no.patch of Package qemu-testsuite

Places