File i386-acpi-Remove-_HID-from-the-SMBus-ACP.patch of Package qemu.22427

Overview Repositories Revisions Requests Users Attributes Meta

File i386-acpi-Remove-_HID-from-the-SMBus-ACP.patch of Package qemu.22427

From: Corey Minyard <cminyard@mvista.com>
Date: Mon, 20 Jan 2020 11:07:25 -0600
Subject: i386:acpi: Remove _HID from the SMBus ACPI entry

Git-commit: aefcaf9d1b3ebb30981627bd08f595211a648a62

Per the ACPI spec (version 6.1, section 6.1.5 _HID) it is not required
on enumerated buses (like PCI in this case), _ADR is required (and is
already there).  And the _HID value is wrong.  Linux appears to ignore
the _HID entry, but Windows 10 detects it as 'Unknown Device' and there
is no driver available.  See https://bugs.launchpad.net/qemu/+bug/1856724

Signed-off-by: Corey Minyard <cminyard@mvista.com>
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <20200120170725.24935-6-minyard@acm.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Bruce Rogers <brogers@suse.com>
[BR: Binary patch part of commit was dropped]
---
 hw/i386/acpi-build.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 90a9c2ce6f8c01221efc56f63f79..b1ad2cb79c09e6c9ffb232acfff1 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -1815,7 +1815,6 @@ static void build_smb0(Aml *table, I2CBus *smbus, int devnr, int func)
     Aml *scope = aml_scope("_SB.PCI0");
     Aml *dev = aml_device("SMB0");
 
-    aml_append(dev, aml_name_decl("_HID", aml_eisaid("APP0005")));
     aml_append(dev, aml_name_decl("_ADR", aml_int(devnr << 16 | func)));
     build_acpi_ipmi_devices(dev, BUS(smbus), "\\_SB.PCI0.SMB0");
     aml_append(scope, dev);

Places

File i386-acpi-Remove-_HID-from-the-SMBus-ACP.patch of Package qemu.22427

Places