File U_04-Remove-problematic-chmod.patch of Package slurm

Overview Repositories Revisions Requests Users Attributes Meta

File U_04-Remove-problematic-chmod.patch of Package slurm (Revision d618866df1316c5875cd64a74c6dbe14)

Currently displaying revision d618866df1316c5875cd64a74c6dbe14 , Show latest

From: Tim Wickberg <tim@schedmd.com>
Date: Wed Oct 11 12:45:25 2023 -0600
Subject: [PATCH 4/19]Remove problematic chmod().
Patch-mainline: Upstream
Git-repo: https://github.com/SchedMD/slurm
Git-commit: 833261474d9bdb39c212b63a5ee60f2d279cd020
References: CVE-2022-29500, bsc#1216207
Signed-off-by: Egbert Eich <eich@suse.de>

Just assume the slurmstepd's umask isn't set to something bizarre, and the
0700 permissions we asked for when creating the directory are in place.

Co-authored-by: Alejandro Sanchez <alex@schedmd.com>
---
 src/plugins/mpi/pmix/pmixp_utils.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/src/plugins/mpi/pmix/pmixp_utils.c b/src/plugins/mpi/pmix/pmixp_utils.c
index aea93954aa..0be02a53f0 100644
--- a/src/plugins/mpi/pmix/pmixp_utils.c
+++ b/src/plugins/mpi/pmix/pmixp_utils.c
@@ -561,14 +561,6 @@ int pmixp_mkdir(char *path)
 		return errno;
 	}
 
-	/* There might be umask that will drop essential rights.
-	 * Fix it explicitly.
-	 * TODO: is there more elegant solution? */
-	if (chmod(path, rights) < 0) {
-		error("%s: chown(%s): %m", __func__, path);
-		return errno;
-	}
-
 	if (chown(path, (uid_t) pmixp_info_jobuid(), (gid_t) -1) < 0) {
 		error("%s: chown(%s): %m", __func__, path);
 		return errno;

Places

File U_04-Remove-problematic-chmod.patch of Package slurm (Revision d618866df1316c5875cd64a74c6dbe14)

Places