File migration-colo-fix-use-after-free-of-loc.patch of Package qemu

Overview Repositories Revisions Requests Users Attributes Meta

File migration-colo-fix-use-after-free-of-loc.patch of Package qemu (Revision 6ae819d595e02e37221f5b1eac852e3a)

Currently displaying revision 6ae819d595e02e37221f5b1eac852e3a , Show latest

From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Date: Tue, 24 Mar 2020 18:36:28 +0300
Subject: migration/colo: fix use after free of local_err

Git-commit: 27d07fcfa70c3afa0664288cbce5334ed9595a3a

local_err is used again in secondary_vm_do_failover() after
replication_stop_all(), so we must zero it. Otherwise try to set
non-NULL local_err will crash.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200324153630.11882-5-vsementsov@virtuozzo.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Bruce Rogers <brogers@suse.com>
---
 migration/colo.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/migration/colo.c b/migration/colo.c
index 2c88aa57a29307963a15fc017b1d..6d46800aa6a2617521a36cc0dc33 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -92,6 +92,7 @@ static void secondary_vm_do_failover(void)
     replication_stop_all(true, &local_err);
     if (local_err) {
         error_report_err(local_err);
+        local_err = NULL;
     }
 
     /* Notify all filters of all NIC to do checkpoint */

Places

File migration-colo-fix-use-after-free-of-loc.patch of Package qemu (Revision 6ae819d595e02e37221f5b1eac852e3a)

Places