File 0001-unlock_indicator.c-fix-build-failure-again... of Package i3lock

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-unlock_indicator.c-fix-build-failure-against-gcc-10.patch of Package i3lock (Revision 3702a8ecad5913d3c46f8ba7493e895d)

Currently displaying revision 3702a8ecad5913d3c46f8ba7493e895d , Show latest

From 3daf34bb03841f8e201ceb14b7124945d4c18bb8 Mon Sep 17 00:00:00 2001
From: Jeroen Roovers <jer@gentoo.org>
Date: Sat, 25 Jan 2020 11:28:36 +0000
Subject: [PATCH] unlock_indicator.c: fix build failure against gcc-10

On gcc-10 (and gcc-9 -fno-common) build fails as:

```
  CCLD     i3lock
ld: i3lock-unlock_indicator.o:i3lock/unlock_indicator.c:38:
  multiple definition of `input_position'; i3lock-i3lock.o:i3lock/i3lock.c:69: first defined here
ld: i3lock-unlock_indicator.o:(.bss+0x102): multiple definition of `__odr_asan.input_position'; i3lock-i3lock.o:(.bss+0x92b): first defined here
```

gcc-10 will change the default from -fcommon to fno-common:
https://gcc.gnu.org/PR85678.

The error also happens if CFLAGS=-fno-common passed explicitly.

Reported-by: Hans de Graaff
Bug: https://bugs.gentoo.org/706286
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
---
 unlock_indicator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/unlock_indicator.c b/unlock_indicator.c
index 8ff8173..d6237ed 100644
--- a/unlock_indicator.c
+++ b/unlock_indicator.c
@@ -35,7 +35,7 @@ extern bool debug_mode;
 
 /* The current position in the input buffer. Useful to determine if any
  * characters of the password have already been entered or not. */
-int input_position;
+extern int input_position;
 
 /* The lock window. */
 extern xcb_window_t win;

Places

File 0001-unlock_indicator.c-fix-build-failure-against-gcc-10.patch of Package i3lock (Revision 3702a8ecad5913d3c46f8ba7493e895d)

Places