File sudo-CVE-2011-0010.patch of Package sudo

Overview Repositories Revisions Requests Users Attributes Meta

File sudo-CVE-2011-0010.patch of Package sudo (Revision 315675df18c20cfcb145ab4f48efcca5)

Currently displaying revision 315675df18c20cfcb145ab4f48efcca5 , Show latest

# User Todd C. Miller <Todd.Miller@courtesan.com>
# Date 1294760019 18000
# Node ID fe8a94f96542335c02d09fba81077c1dcc6381b5
# Parent  8f9303326db73a2e00cd53c2515db8188386cfc0
If the user is running sudo as himself but as a different group we
need to prompt for a password.

Index: sudo-1.7.2p7/check.c
===================================================================
--- sudo-1.7.2p7.orig/check.c
+++ sudo-1.7.2p7/check.c
@@ -93,7 +93,13 @@ check_user(validated, mode)
 	/* do not check or update timestamp */
 	status = TS_ERROR;
     } else {
-	if (user_uid == 0 || user_uid == runas_pw->pw_uid || user_is_exempt())
+	/*
+	 * Don't prompt for the root passwd or if the user is exempt.
+	 * If the user is not changing uid/gid, no need for a password.
+	 */
+	if (user_uid == 0 || (user_uid == runas_pw->pw_uid &&
+	    (!runas_gr || user_in_group(sudo_user.pw, runas_gr->gr_name))) ||
+	    user_is_exempt())
 	    return;
 
 	build_timestamp(&timestampdir, &timestampfile);
Index: sudo-1.7.2p7/pwutil.c
===================================================================
--- sudo-1.7.2p7.orig/pwutil.c
+++ sudo-1.7.2p7/pwutil.c
@@ -565,3 +565,50 @@ sudo_endgrent()
     sudo_freegrcache();
 #endif
 }
+
+
+int
+user_in_group(struct passwd *pw, const char *group)
+{
+    char **gr_mem;
+    int i;
+    struct group *grp;
+    int retval = FALSE;
+
+    grp = sudo_getgrnam(group);
+    if (grp == NULL)
+	goto done;
+
+    /* check against user's primary (passwd file) gid */
+    if (grp->gr_gid == pw->pw_gid) {
+	retval = TRUE;
+	goto done;
+    }
+
+    /*
+     * If we are matching the invoking or list user and that user has a
+     * supplementary group vector, check it.
+     */
+    if (user_ngroups > 0 &&
+	strcmp(pw->pw_name, list_pw ? list_pw->pw_name : user_name) == 0) {
+	for (i = 0; i < user_ngroups; i++) {
+	    if (grp->gr_gid == user_groups[i]) {
+		retval = TRUE;
+		goto done;
+	    }
+	}
+    } else
+    {
+	if (grp != NULL && grp->gr_mem != NULL) {
+	    for (gr_mem = grp->gr_mem; *gr_mem; gr_mem++) {
+		if (strcmp(*gr_mem, pw->pw_name) == 0) {
+		    retval = TRUE;
+		    goto done;
+		}
+	    }
+	}
+    }
+
+done:
+    return(retval);
+}
Index: sudo-1.7.2p7/sudo.h
===================================================================
--- sudo-1.7.2p7.orig/sudo.h
+++ sudo-1.7.2p7/sudo.h
@@ -316,6 +316,7 @@ struct passwd *sudo_getpwuid __P((uid_t)
 struct group *sudo_getgrnam __P((const char *));
 struct group *sudo_fakegrnam __P((const char *));
 struct group *sudo_getgrgid __P((gid_t));
+int user_in_group(struct passwd *pw, const char *group);
 #ifdef HAVE_SELINUX
 void selinux_exec __P((char *, char *, char **, int));
 #endif

Places

File sudo-CVE-2011-0010.patch of Package sudo (Revision 315675df18c20cfcb145ab4f48efcca5)

Places