File 22019-x86-cpuidle-online-check.patch of Package xen

Overview Repositories Revisions Requests Users Attributes Meta

File 22019-x86-cpuidle-online-check.patch of Package xen (Revision 1dca0e23b6cc8bdf8eb416dac40ba7f7)

Currently displaying revision 1dca0e23b6cc8bdf8eb416dac40ba7f7 , Show latest

# HG changeset patch
# User Keir Fraser <keir.fraser@citrix.com>
# Date 1282069957 -3600
# Node ID 5218db847b58a151d8f320b7141efc984f759b35
# Parent  542e8cd16a6cf036e89b597ba6343245fcaafa25
x86 cpuidle: check whether cpu is online in cpu idle control

We observed a 2.6.18.8 dom0 kernel crash when Xen has maxcpus < num
of physical cores (maxcpus=3D4 for a 12-core system). It appeared that
hypervisor doesn't check whether CPU is online or not. This small
patch fixed the issue.

Signed-off-by: Uwe Dannowski <uwe.dannowski@amd.com>
Acked-by: Wei Huang <wei.huang2@amd.com>

--- a/xen/arch/x86/acpi/cpuidle_menu.c
+++ b/xen/arch/x86/acpi/cpuidle_menu.c
@@ -270,9 +270,10 @@ static void menu_reflect(struct acpi_pro
 
 static int menu_enable_device(struct acpi_processor_power *power)
 {
-    struct menu_device *data = &per_cpu(menu_devices, power->cpu);
+    if (!cpu_online(power->cpu))
+        return -1;
 
-    memset(data, 0, sizeof(struct menu_device));
+    memset(&per_cpu(menu_devices, power->cpu), 0, sizeof(struct menu_device));
 
     return 0;
 }

Places

File 22019-x86-cpuidle-online-check.patch of Package xen (Revision 1dca0e23b6cc8bdf8eb416dac40ba7f7)

Places