File libxl.add-option-to-disable-disk-cache-flushes-... of Package xen

Overview Repositories Revisions Requests Users Attributes Meta

File libxl.add-option-to-disable-disk-cache-flushes-in-qdisk.patch of Package xen (Revision 01bb0831d5e3e9eb8d574253efbd1730)

Currently displaying revision 01bb0831d5e3e9eb8d574253efbd1730 , Show latest

https://bugzilla.novell.com/show_bug.cgi?id=879425
---
 tools/libxl/libxl.c         |    2 ++
 tools/libxl/libxl.h         |   12 ++++++++++++
 tools/libxl/libxlu_disk.c   |    2 ++
 tools/libxl/libxlu_disk_i.h |    2 +-
 tools/libxl/libxlu_disk_l.l |    1 +
 5 files changed, 18 insertions(+), 1 deletion(-)

Index: xen-4.10.0-testing/tools/libxl/libxl_disk.c
===================================================================
--- xen-4.10.0-testing.orig/tools/libxl/libxl_disk.c
+++ xen-4.10.0-testing/tools/libxl/libxl_disk.c
@@ -406,6 +406,8 @@ static void device_disk_add(libxl__egc *
         flexarray_append_pair(back, "discard-enable",
                               libxl_defbool_val(disk->discard_enable) ?
                               "1" : "0");
+        if ((disk->readwrite & ~LIBXL_HAVE_LIBXL_DEVICE_DISK_DISABLE_FLUSH_MASK) == LIBXL_HAVE_LIBXL_DEVICE_DISK_DISABLE_FLUSH_MAGIC)
+            flexarray_append_pair(back, "suse-diskcache-disable-flush", "1");
 
         flexarray_append(front, "backend-id");
         flexarray_append(front, GCSPRINTF("%d", disk->backend_domid));
Index: xen-4.10.0-testing/tools/libxl/libxl.h
===================================================================
--- xen-4.10.0-testing.orig/tools/libxl/libxl.h
+++ xen-4.10.0-testing/tools/libxl/libxl.h
@@ -348,6 +348,18 @@
 #define LIBXL_HAVE_BUILDINFO_BOOTLOADER_ARGS 1
 
 /*
+ * The libxl_device_disk has no way to indicate that cache=unsafe is
+ * supposed to be used. Provide this knob without breaking the ABI.
+ * This is done by overloading struct libxl_device_disk->readwrite:
+ * readwrite == 0: disk is readonly, no discard
+ * readwrite == 1: disk is readwrite, backend driver may enable discard
+ * readwrite == MAGIC: disk is readwrite, backend driver should ignore
+ * flush requests from the frontend driver.
+ */
+#define LIBXL_HAVE_LIBXL_DEVICE_DISK_DISABLE_FLUSH_MAGIC 0x00006000U
+#define LIBXL_HAVE_LIBXL_DEVICE_DISK_DISABLE_FLUSH_MASK  0xffff0fffU
+
+/*
  * libxl ABI compatibility
  *
  * The only guarantee which libxl makes regarding ABI compatibility
Index: xen-4.10.0-testing/tools/libxl/libxlu_disk.c
===================================================================
--- xen-4.10.0-testing.orig/tools/libxl/libxlu_disk.c
+++ xen-4.10.0-testing/tools/libxl/libxlu_disk.c
@@ -79,6 +79,8 @@ int xlu_disk_parse(XLU_Config *cfg,
         if (!disk->pdev_path || !strcmp(disk->pdev_path, ""))
             disk->format = LIBXL_DISK_FORMAT_EMPTY;
     }
+    if (disk->readwrite && dpc.suse_diskcache_disable_flush)
+        disk->readwrite = (disk->readwrite & LIBXL_HAVE_LIBXL_DEVICE_DISK_DISABLE_FLUSH_MASK) | LIBXL_HAVE_LIBXL_DEVICE_DISK_DISABLE_FLUSH_MAGIC;
 
     if (!disk->vdev) {
         xlu__disk_err(&dpc,0, "no vdev specified");
Index: xen-4.10.0-testing/tools/libxl/libxlu_disk_i.h
===================================================================
--- xen-4.10.0-testing.orig/tools/libxl/libxlu_disk_i.h
+++ xen-4.10.0-testing/tools/libxl/libxlu_disk_i.h
@@ -10,7 +10,7 @@ typedef struct {
     void *scanner;
     YY_BUFFER_STATE buf;
     libxl_device_disk *disk;
-    int access_set, had_depr_prefix;
+    int access_set, suse_diskcache_disable_flush, had_depr_prefix;
     const char *spec;
 } DiskParseContext;
 
Index: xen-4.10.0-testing/tools/libxl/libxlu_disk_l.l
===================================================================
--- xen-4.10.0-testing.orig/tools/libxl/libxlu_disk_l.l
+++ xen-4.10.0-testing/tools/libxl/libxlu_disk_l.l
@@ -196,6 +196,7 @@ colo-port=[^,]*,?	{ STRIP(','); setcolop
 colo-export=[^,]*,?	{ STRIP(','); SAVESTRING("colo-export", colo_export, FROMEQUALS); }
 active-disk=[^,]*,?	{ STRIP(','); SAVESTRING("active-disk", active_disk, FROMEQUALS); }
 hidden-disk=[^,]*,?	{ STRIP(','); SAVESTRING("hidden-disk", hidden_disk, FROMEQUALS); }
+suse-diskcache-disable-flush,? { DPC->suse_diskcache_disable_flush = 1; }
 
  /* the target magic parameter, eats the rest of the string */
 
Index: xen-4.10.0-testing/docs/man/xl-disk-configuration.pod.5
===================================================================
--- xen-4.10.0-testing.orig/docs/man/xl-disk-configuration.pod.5
+++ xen-4.10.0-testing/docs/man/xl-disk-configuration.pod.5
@@ -344,6 +344,32 @@ can be used to disable "hole punching" f
 were intentionally created non-sparse to avoid fragmentation of the
 file.
 
+=item B<suse-diskcache-disable-flush>
+
+=over 4
+
+=item Description
+
+Request that the qemu block driver does not automatically flush written data to the backend storage.
+
+=item Supported values
+
+absent, present
+
+=item Mandatory
+
+No
+
+=item Default value
+
+absent
+
+=back
+
+This enables the '-disk cache=unsafe' mode inside qemu.
+In this mode writes to the underlying blockdevice are delayed.
+While using this option in production is dangerous, it improves performance during installation of a domU.
+
 =back

Places

File libxl.add-option-to-disable-disk-cache-flushes-in-qdisk.patch of Package xen (Revision 01bb0831d5e3e9eb8d574253efbd1730)

Places