File totem-fix-properties-crash.patch of Package totem

Overview Repositories Revisions Requests Users Attributes Meta

File totem-fix-properties-crash.patch of Package totem (Revision 55c758aa2ee507fb359ba75d36874f82)

Currently displaying revision 55c758aa2ee507fb359ba75d36874f82 , Show latest

From 57ceb48f4db464f785a084859c55ad20cbc639f5 Mon Sep 17 00:00:00 2001
From: Bastien Nocera <hadess@hadess.net>
Date: Thu, 21 Sep 2017 20:04:31 +0200
Subject: properties: Fix crash when properties are closed fast

Cancel the GstDiscoverer process when closing the window.

https://bugzilla.gnome.org/show_bug.cgi?id=787996
---
 src/totem-properties-view.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/totem-properties-view.c b/src/totem-properties-view.c
index bf681c8..51c1334 100644
--- a/src/totem-properties-view.c
+++ b/src/totem-properties-view.c
@@ -345,7 +345,13 @@ totem_properties_view_finalize (GObject *object)
 	props = TOTEM_PROPERTIES_VIEW (object);
 
 	if (props->priv != NULL) {
-		g_clear_object (&props->priv->disco);
+		if (props->priv->disco) {
+			g_signal_handlers_disconnect_by_func (props->priv->disco,
+							      discovered_cb,
+							      props);
+			gst_discoverer_stop (props->priv->disco);
+			g_clear_object (&props->priv->disco);
+		}
 		g_clear_object (&props->priv->label);
 		g_free (props->priv);
 	}
-- 
cgit v0.12

Places

File totem-fix-properties-crash.patch of Package totem (Revision 55c758aa2ee507fb359ba75d36874f82)

Places