File totem-thumbnailer-blacklist-fixes.patch of Package totem

Overview Repositories Revisions Requests Users Attributes Meta

File totem-thumbnailer-blacklist-fixes.patch of Package totem (Revision 55c758aa2ee507fb359ba75d36874f82)

Currently displaying revision 55c758aa2ee507fb359ba75d36874f82 , Show latest

From 5f0f049416df05b17926e45b0d54a30dc943588b Mon Sep 17 00:00:00 2001
From: Robert McQueen <rob@endlessm.com>
Date: Wed, 15 Nov 2017 17:23:57 +0000
Subject: thumbnailer: Blacklist GStreamer plugins rather than features

This avoids the need to check multiple entries and changing feature
names in upstream GStreamer.

https://bugzilla.gnome.org/show_bug.cgi?id=790491
---
 src/totem-video-thumbnailer.c | 28 ++++++++++------------------
 1 file changed, 10 insertions(+), 18 deletions(-)

diff --git a/src/totem-video-thumbnailer.c b/src/totem-video-thumbnailer.c
index 7d20f16..39d2d87 100644
--- a/src/totem-video-thumbnailer.c
+++ b/src/totem-video-thumbnailer.c
@@ -386,18 +386,11 @@ thumb_app_setup_play (ThumbApp *app)
 	GstElement *play;
 	GstElement *audio_sink, *video_sink;
 	GstRegistry *registry;
-        const char *blacklisted_plugins[] = {
-          "vaapidecodebin",
-          "vaapidecode",
-          "vaapimpeg2dec",
-          "vaapih264dec",
-          "vaapivc1dec",
-          "vaapivp8dec",
-          "vaapivp9dec",
-          "vaapih265dec",
-          "bmcdec"
-        };
-        guint i;
+	const char *blacklisted_plugins[] = {
+	  "bmcdec",
+	  "vaapi"
+	};
+	guint i;
 
 	play = gst_element_factory_make ("playbin", "play");
 	audio_sink = gst_element_factory_make ("fakesink", "audio-fake-sink");
@@ -419,12 +412,11 @@ thumb_app_setup_play (ThumbApp *app)
 	registry = gst_registry_get ();
 
 	for (i = 0; i < G_N_ELEMENTS (blacklisted_plugins); i++) {
-		GstPluginFeature *feature =
-			gst_registry_find_feature (registry,
-						   blacklisted_plugins[i],
-						   GST_TYPE_ELEMENT_FACTORY);
-		if (feature)
-			gst_registry_remove_feature (registry, feature);
+		GstPlugin *plugin =
+			gst_registry_find_plugin (registry,
+						  blacklisted_plugins[i]);
+		if (plugin)
+			gst_registry_remove_plugin (registry, plugin);
 	}
 }
 
-- 
cgit v0.12

From 621a387cbe88c8084796dd601e1efc95b6fd2c00 Mon Sep 17 00:00:00 2001
From: Robert McQueen <rob@endlessm.com>
Date: Wed, 15 Nov 2017 17:27:33 +0000
Subject: thumbnailer: Blacklist video4linux2 plugin

On most V4L2 platforms supported by GStreamer, there are a finite number
of M2M decoders and if the thumbnailer is using them, it prevents the
user from playing back their real video.

https://bugzilla.gnome.org/show_bug.cgi?id=790491
---
 src/totem-video-thumbnailer.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/totem-video-thumbnailer.c b/src/totem-video-thumbnailer.c
index 39d2d87..2caafa5 100644
--- a/src/totem-video-thumbnailer.c
+++ b/src/totem-video-thumbnailer.c
@@ -388,7 +388,8 @@ thumb_app_setup_play (ThumbApp *app)
 	GstRegistry *registry;
 	const char *blacklisted_plugins[] = {
 	  "bmcdec",
-	  "vaapi"
+	  "vaapi",
+	  "video4linux2"
 	};
 	guint i;
 
-- 
cgit v0.12

Places

File totem-thumbnailer-blacklist-fixes.patch of Package totem (Revision 55c758aa2ee507fb359ba75d36874f82)

Places