File 0001-CLI-reindex-fix-memory-leak.patch of Package notmuch

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-CLI-reindex-fix-memory-leak.patch of Package notmuch (Revision 3fae3d5bcbaf672dd3644fd930fd01be)

Currently displaying revision 3fae3d5bcbaf672dd3644fd930fd01be , Show latest

From a9305cb9bcd8e4b720b71d19d9987397cade0fab Mon Sep 17 00:00:00 2001
From: David Bremner <david@tethera.net>
Date: Mon, 15 Apr 2019 22:46:15 -0300
Subject: [PATCH] CLI/reindex: fix memory leak

Since message is owned by messages, it was held for the entire run of
the program. This in turn means that the Xapian::Document objects are
not freed, and thus one ends up with (effectively) a copy of one's
entire mailstore in memory when running

notmuch reindex '*'

Thanks to Olly Betts for the patient help debugging, and the
suggestion of a fix.
---
 notmuch-reindex.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/notmuch-reindex.c b/notmuch-reindex.c
index d8589120..fefa7c63 100644
--- a/notmuch-reindex.c
+++ b/notmuch-reindex.c
@@ -71,6 +71,7 @@ reindex_query (notmuch_database_t *notmuch, const char *query_string,
 	ret = notmuch_message_reindex(message, indexopts);
 	if (ret != NOTMUCH_STATUS_SUCCESS)
 	    break;
+	notmuch_message_destroy (message);
     }
 
     if (!ret)
-- 
2.21.0

Places

File 0001-CLI-reindex-fix-memory-leak.patch of Package notmuch (Revision 3fae3d5bcbaf672dd3644fd930fd01be)

Places