File do-fclose.patch of Package OpenIPMI

Overview Repositories Revisions Requests Users Attributes Meta

File do-fclose.patch of Package OpenIPMI (Revision 0f74561655ac793c5e15e374228c0591)

Currently displaying revision 0f74561655ac793c5e15e374228c0591 , Show latest

Fix file descriptor leaks and a memory leak in error case

Signed-off-by: Thomas Renninger <trenn@suse.de>

diff -wruN -x '*~' -x '*.o' -x '*.a' -x '*.so' -x '*.so.[0-9]' -x autom4te.cache -x .deps -x .libs ../orig-OpenIPMI-2.0.20-rc3/lanserv/config.c ./lanserv/config.c
--- ../orig-OpenIPMI-2.0.20-rc3/lanserv/config.c	2013-01-21 18:24:13.000000000 +0100
+++ ./lanserv/config.c	2013-10-04 09:46:41.322610344 +0200
@@ -816,8 +816,6 @@
 	    }
 	    if (!err) {
 		err = lanserv_read_config(sys, f, &line, val);
-		if (err)
-		    return err;
 	    }
 	} else if (strcmp(tok, "user") == 0) {
 	    err = get_user(&tokptr, sys, &errstr);
@@ -874,7 +872,7 @@
       next:
 	if (err) {
 	    fprintf(stderr, "Error on line %d: %s\n", line, errstr);
-	    return err;
+	    break;
 	}
     }
 
@@ -883,5 +881,5 @@
     if (print_version)
 	load_dynamic_libs(sys, print_version);
 
-    return 0;
+    return err;
 }
diff -wruN -x '*~' -x '*.o' -x '*.a' -x '*.so' -x '*.so.[0-9]' -x autom4te.cache -x .deps -x .libs ../orig-OpenIPMI-2.0.20-rc3/lanserv/emu_cmd.c ./lanserv/emu_cmd.c
--- ../orig-OpenIPMI-2.0.20-rc3/lanserv/emu_cmd.c	2013-08-29 03:30:25.000000000 +0200
+++ ./lanserv/emu_cmd.c	2013-10-04 09:47:58.429779879 +0200
@@ -235,7 +235,7 @@
 	    
 	    rv = ipmi_emu_cmd(out, emu, buffer);
 	    if (rv)
-		return rv;
+		break;
 	    pos = 0;
 	}
  out:

Places

File do-fclose.patch of Package OpenIPMI (Revision 0f74561655ac793c5e15e374228c0591)

Places