File shim-improve-error-messages.patch of Package shim

Overview Repositories Revisions Requests Users Attributes Meta

File shim-improve-error-messages.patch of Package shim

commit 2f09d0ab290d9b0d8aa14c3243f1d85a20bc34e6
Author: Andrew Boie <andrew.p.boie@intel.com>
Date:   Mon Nov 11 17:29:06 2013 -0800

shim: improve error messages
    
    %r when used in Print() will show a string representation of
    an EFI_STATUS code.
    
    Change-Id: I6db47f5213454603bd66177aca378ad01e9f0bd4
    Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>

Index: shim-0.7/shim.c
===================================================================
--- shim-0.7.orig/shim.c
+++ shim-0.7/shim.c
@@ -888,7 +888,7 @@ static EFI_STATUS handle_image (void *da
 	 */
 	efi_status = read_header(data, datasize, &context);
 	if (efi_status != EFI_SUCCESS) {
-		Print(L"Failed to read header\n");
+		Print(L"Failed to read header: %r\n", efi_status);
 		return efi_status;
 	}
 
@@ -955,7 +955,7 @@ static EFI_STATUS handle_image (void *da
 	efi_status = relocate_coff(&context, buffer);
 
 	if (efi_status != EFI_SUCCESS) {
-		Print(L"Relocation failed\n");
+		Print(L"Relocation failed: %r\n", efi_status);
 		FreePool(buffer);
 		return efi_status;
 	}
@@ -996,7 +996,7 @@ should_use_fallback(EFI_HANDLE image_han
 	rc = uefi_call_wrapper(BS->HandleProtocol, 3, image_handle,
 				       &loaded_image_protocol, (void **)&li);
 	if (EFI_ERROR(rc)) {
-		Print(L"Could not get image for bootx64.efi: %d\n", rc);
+		Print(L"Could not get image for bootx64.efi: %r\n", rc);
 		return 0;
 	}
 
@@ -1018,13 +1018,13 @@ should_use_fallback(EFI_HANDLE image_han
 	rc = uefi_call_wrapper(BS->HandleProtocol, 3, li->DeviceHandle,
 			       &FileSystemProtocol, (void **)&fio);
 	if (EFI_ERROR(rc)) {
-		Print(L"Could not get fio for li->DeviceHandle: %d\n", rc);
+		Print(L"Could not get fio for li->DeviceHandle: %r\n", rc);
 		return 0;
 	}
 	
 	rc = uefi_call_wrapper(fio->OpenVolume, 2, fio, &vh);
 	if (EFI_ERROR(rc)) {
-		Print(L"Could not open fio volume: %d\n", rc);
+		Print(L"Could not open fio volume: %r\n", rc);
 		return 0;
 	}
 
@@ -1146,14 +1146,14 @@ static EFI_STATUS load_image (EFI_LOADED
 				       (void **)&drive);
 
 	if (efi_status != EFI_SUCCESS) {
-		Print(L"Failed to find fs\n");
+		Print(L"Failed to find fs: %r\n", efi_status);
 		goto error;
 	}
 
 	efi_status = uefi_call_wrapper(drive->OpenVolume, 2, drive, &root);
 
 	if (efi_status != EFI_SUCCESS) {
-		Print(L"Failed to open fs\n");
+		Print(L"Failed to open fs: %r\n", efi_status);
 		goto error;
 	}
 
@@ -1164,7 +1164,7 @@ static EFI_STATUS load_image (EFI_LOADED
 				       EFI_FILE_MODE_READ, 0);
 
 	if (efi_status != EFI_SUCCESS) {
-		Print(L"Failed to open %s - %lx\n", PathName, efi_status);
+		Print(L"Failed to open %s - %r\n", PathName, efi_status);
 		goto error;
 	}
 
@@ -1197,7 +1197,7 @@ static EFI_STATUS load_image (EFI_LOADED
 	}
 
 	if (efi_status != EFI_SUCCESS) {
-		Print(L"Unable to get file info\n");
+		Print(L"Unable to get file info: %r\n", efi_status);
 		goto error;
 	}
 
@@ -1225,7 +1225,7 @@ static EFI_STATUS load_image (EFI_LOADED
 	}
 
 	if (efi_status != EFI_SUCCESS) {
-		Print(L"Unexpected return from initial read: %x, buffersize %x\n", efi_status, buffersize);
+		Print(L"Unexpected return from initial read: %r, buffersize %x\n", efi_status, buffersize);
 		goto error;
 	}
 
@@ -1302,20 +1302,20 @@ EFI_STATUS start_image(EFI_HANDLE image_
 	efi_status = generate_path(li, ImagePath, &path, &PathName);
 
 	if (efi_status != EFI_SUCCESS) {
-		Print(L"Unable to generate path: %s\n", ImagePath);
+		Print(L"Unable to generate path %s: %r\n", ImagePath, efi_status);
 		goto done;
 	}
 
 	if (findNetboot(image_handle)) {
 		efi_status = parseNetbootinfo(image_handle);
 		if (efi_status != EFI_SUCCESS) {
-			Print(L"Netboot parsing failed: %d\n", efi_status);
+			Print(L"Netboot parsing failed: %r\n", efi_status);
 			return EFI_PROTOCOL_ERROR;
 		}
 		efi_status = FetchNetbootimage(image_handle, &sourcebuffer,
 					       &sourcesize);
 		if (efi_status != EFI_SUCCESS) {
-			Print(L"Unable to fetch TFTP image\n");
+			Print(L"Unable to fetch TFTP image: %r\n", efi_status);
 			return efi_status;
 		}
 		data = sourcebuffer;
@@ -1327,7 +1327,7 @@ EFI_STATUS start_image(EFI_HANDLE image_
 		efi_status = load_image(li, &data, &datasize, PathName);
 
 		if (efi_status != EFI_SUCCESS) {
-			Print(L"Failed to load image\n");
+			Print(L"Failed to load image %s: %r\n", PathName, efi_status);
 			goto done;
 		}
 	}
@@ -1344,7 +1344,7 @@ EFI_STATUS start_image(EFI_HANDLE image_
 	efi_status = handle_image(data, datasize, li);
 
 	if (efi_status != EFI_SUCCESS) {
-		Print(L"Failed to load image\n");
+		Print(L"Failed to load image: %r\n", efi_status);
 		CopyMem(li, &li_bak, sizeof(li_bak));
 		goto done;
 	}
@@ -1447,7 +1447,7 @@ EFI_STATUS mirror_mok_list()
 				       | EFI_VARIABLE_RUNTIME_ACCESS,
 				       FullDataSize, FullData);
 	if (efi_status != EFI_SUCCESS) {
-		Print(L"Failed to set MokListRT %d\n", efi_status);
+		Print(L"Failed to set MokListRT: %r\n", efi_status);
 	}
 
 	return efi_status;
@@ -1488,7 +1488,7 @@ EFI_STATUS check_mok_request(EFI_HANDLE
 		efi_status = start_image(image_handle, MOK_MANAGER);
 
 		if (efi_status != EFI_SUCCESS) {
-			Print(L"Failed to start MokManager\n");
+			Print(L"Failed to start MokManager: %r\n", efi_status);
 			return efi_status;
 		}
 	}
@@ -1595,7 +1595,7 @@ static EFI_STATUS mok_ignore_db()
 				| EFI_VARIABLE_RUNTIME_ACCESS,
 				DataSize, (void *)&Data);
 		if (efi_status != EFI_SUCCESS) {
-			Print(L"Failed to set MokIgnoreDB %d\n", efi_status);
+			Print(L"Failed to set MokIgnoreDB: %r\n", efi_status);
 		}
 	}
 
@@ -1622,7 +1622,7 @@ EFI_STATUS set_second_stage (EFI_HANDLE
 	status = uefi_call_wrapper(BS->HandleProtocol, 3, image_handle,
 				   &LoadedImageProtocol, (void **) &li);
 	if (status != EFI_SUCCESS) {
-		Print (L"Failed to get load options\n");
+		Print (L"Failed to get load options: %r\n", status);
 		return status;
 	}

Places

File shim-improve-error-messages.patch of Package shim

Places