File 5642-compiler-tests-Correct-bad-timetrap-limit.... of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 5642-compiler-tests-Correct-bad-timetrap-limit.patch of Package erlang

From 9a6084d119cd50608cb34b5f24e75f1f347b59ba Mon Sep 17 00:00:00 2001
From: Frej Drejhammar <frej.drejhammar@gmail.com>
Date: Fri, 19 Jul 2024 07:57:31 +0200
Subject: [PATCH] compiler tests: Correct bad timetrap limit

The compiler's random_code test suite always fails when running with a
debug emulator due to a `timeout_value` exit. A `timeout_value` exit
appears to be triggered when a timer is given a timeout that is either
miss-formed or out of range. Checking the relevant part of
`random_code_SUITE`, it appears that the timeout is calculated in
milliseconds, but it is given to `ct:timetrap/1` as a timeout in
seconds.

Although not sure about the exact failure mechanism, changing the
calculation to produce a timeout in seconds, allows the test-suite to
successfully complete both with an `opt` and `debug` build of the
emulator.
---
 lib/compiler/test/random_code_SUITE.erl | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/compiler/test/random_code_SUITE.erl b/lib/compiler/test/random_code_SUITE.erl
index 2c242ba437..80f43e0970 100644
--- a/lib/compiler/test/random_code_SUITE.erl
+++ b/lib/compiler/test/random_code_SUITE.erl
@@ -58,8 +58,9 @@ compile(_Config) ->
                        list_to_integer(NumTests0)
                end,
 
-    %% Conservatively assume that we can run 10 tests each second.
-    TimeTrap = {seconds,60_000 + (NumTests+99) div 100},
+    %% Conservatively assume that we can run 10 tests each
+    %% second.
+    TimeTrap = {seconds, (60 + (NumTests+9) div 10)},
     ct:timetrap(TimeTrap),
     io:format("~p tests\n", [NumTests]),
     true = proper:quickcheck(compile_prop:compile(),
-- 
2.43.0

Places

File 5642-compiler-tests-Correct-bad-timetrap-limit.patch of Package erlang

Places