File 0128-ssh-Check-the-generated-known_hosts-file.p... of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 0128-ssh-Check-the-generated-known_hosts-file.patch of Package erlang (Revision 8fd52fb4d57422a794f6f91425cd74a9)

Currently displaying revision 8fd52fb4d57422a794f6f91425cd74a9 , Show latest

From 20690b7c4f5409216db5538784482f54b993959a Mon Sep 17 00:00:00 2001
From: Hans Nilsson <hans@erlang.org>
Date: Fri, 21 May 2021 10:55:45 +0200
Subject: [PATCH 2/2] ssh: Check the generated known_hosts file

---
 lib/ssh/test/ssh_pubkey_SUITE.erl | 55 +++++++++++++++++++++++++++++--
 1 file changed, 53 insertions(+), 2 deletions(-)

diff --git a/lib/ssh/test/ssh_pubkey_SUITE.erl b/lib/ssh/test/ssh_pubkey_SUITE.erl
index 481666d25e..14cc1de96f 100644
--- a/lib/ssh/test/ssh_pubkey_SUITE.erl
+++ b/lib/ssh/test/ssh_pubkey_SUITE.erl
@@ -83,7 +83,8 @@
          ssh_hostkey_fingerprint_sha256/1,
          ssh_hostkey_fingerprint_sha384/1,
          ssh_hostkey_fingerprint_sha512/1,
-         ssh_hostkey_fingerprint_list/1
+         ssh_hostkey_fingerprint_list/1,
+         chk_known_hosts/1
         ]).
 
 -include_lib("common_test/include/ct.hrl").
@@ -103,7 +104,8 @@ suite() ->
      {group, new_format},
      {group, option_space},
      {group, ssh_hostkey_fingerprint},
-     {group, ssh_public_key_decode_encode}
+     {group, ssh_public_key_decode_encode},
+     chk_known_hosts
     ].
 
 
@@ -784,6 +786,54 @@ connect_ed448_to_ed448(Config) ->
 	  public_key),
     PKdecoded.
 
+%%%----------------------------------------------------------------
+chk_known_hosts(Config) ->
+    PrivDir = proplists:get_value(priv_dir, Config),
+
+    DataDir = filename:join(proplists:get_value(data_dir,Config), "new_format"),
+    SysDir = filename:join(PrivDir, "chk_known_hosts_sys_dir"),
+    ssh_test_lib:setup_all_host_keys(DataDir, SysDir),
+
+    UsrDir = filename:join(PrivDir, "chk_known_hosts_usr_dir"),
+    file:make_dir(UsrDir),
+    KnownHostsFile = filename:join(UsrDir, "known_hosts"),
+
+    DaemonOpts = [{system_dir, SysDir},
+                  {user_dir, UsrDir},
+                  {password, "bar"}],
+
+    UserOpts = [{user_dir, UsrDir},
+                {user, "foo"},
+                {password, "bar"},
+                {silently_accept_hosts, true},
+                {user_interaction, false}
+               ],
+
+    {_Pid1, Host1, Port1} = ssh_test_lib:daemon(DaemonOpts),
+    {_Pid2, Host2, Port2} = ssh_test_lib:daemon(DaemonOpts),
+
+    _C1 = ssh_test_lib:connect(Host1, Port1, UserOpts),
+    {ok,KnownHosts1} = file:read_file(KnownHostsFile),
+    Sz1 = byte_size(KnownHosts1),
+    ct:log("~p bytes KnownHosts1 = ~p", [Sz1, KnownHosts1]),
+
+    _C2 = ssh_test_lib:connect(Host2, Port2, UserOpts),
+    {ok,KnownHosts2} = file:read_file(KnownHostsFile),
+    Sz2 = byte_size(KnownHosts2),
+    ct:log("~p bytes KnownHosts2 = ~p", [Sz2, KnownHosts2]),
+
+    %% Check that 2nd is appended after the 1st:
+    <<KnownHosts1:Sz1/binary, _/binary>> = KnownHosts2,
+
+    %% Check that there are exactly two NLs:
+    2 = lists:foldl(fun($\n, Sum) -> Sum + 1;
+                       (_,   Sum) -> Sum
+                    end, 0, binary_to_list(KnownHosts2)),
+
+    %% Check that at least one NL terminates both two lines:
+    <<_:(Sz1-1)/binary, $\n, _:(Sz2-Sz1-1)/binary, $\n>> = KnownHosts2.
+
+
 %%%----------------------------------------------------------------
 try_connect({skip,Reson}) ->
     {skip,Reson};
-- 
2.26.2

Places

File 0128-ssh-Check-the-generated-known_hosts-file.patch of Package erlang (Revision 8fd52fb4d57422a794f6f91425cd74a9)

Places