File 0208-erts-Remove-CFBundle-fields-from-Info.plis... of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 0208-erts-Remove-CFBundle-fields-from-Info.plist.patch of Package erlang (Revision de16d5bb9b1e73f72aa79d2ecdf361ff)

Currently displaying revision de16d5bb9b1e73f72aa79d2ecdf361ff , Show latest

From a4650993d2137f551a5f1a959d18216a6da32ed2 Mon Sep 17 00:00:00 2001
From: Wojtek Mach <wojtek@wojtekmach.pl>
Date: Tue, 16 Nov 2021 14:04:58 +0100
Subject: [PATCH] erts: Remove `CFBundle*` fields from `Info.plist`

I'm building an `.app` bundle with it's own `Info.plist`. In my plist,
the values I'm putting in seem to ignored, when running the app,
the app name in the menu bar is always "Erlang".

With this patch, the `CFBundle*` from my app's plist take effect.

One should be able to re-produce this issue by executing this shell
script:

```sh
set -e

rm -rf Example.app
mkdir -p Example.app/Contents/MacOS

cat <<EOF > Example.app/Contents/Info.plist
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
  <key>CFBundleName</key>
  <string>Example</string>
  <key>CFBundleDisplayName</key>
  <string>Example</string>
</dict>
</plist>
EOF

cat <<EOF > Example.app/Contents/MacOS/Example
erl -noshell -eval '
Wx=wx:new(), F=wxFrame:new(Wx,-1,"Example",[]), wxFrame:show(F),

%% listen for menubar events, in particular cmd+q so we can quit.
MenuBar = wxMenuBar:new(), wxFrame:setMenuBar(F,MenuBar),
wxFrame:connect(F,command_menu_selected),
receive Event ->
    io:format("~p~n", [Event])
end,
halt().
' > ~/Example.stdout 2> ~/Example.stderr
EOF

chmod +x Example.app/Contents/MacOS/Example
open Example.app
```
---
 erts/etc/darwin/Info.plist | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/erts/etc/darwin/Info.plist b/erts/etc/darwin/Info.plist
index a12bcd9d68..3896524588 100644
--- a/erts/etc/darwin/Info.plist
+++ b/erts/etc/darwin/Info.plist
@@ -2,14 +2,6 @@
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
 <dict>
-	<key>CFBundleName</key>
-	<string>Erlang</string>
-	<key>CFBundleDisplayname</key>
-	<string>Erlang</string>
-	<key>CFBundleDevelopmentRegion</key>
-	<string>English</string>
-	<key>CFBundleIdentifier</key>
-	<string>org.erlang.beam</string>
 	<key>NSAppTransportSecurity</key>
 	<dict>
 		<key>NSExceptionDomains</key>
-- 
2.31.1

Places

File 0208-erts-Remove-CFBundle-fields-from-Info.plist.patch of Package erlang (Revision de16d5bb9b1e73f72aa79d2ecdf361ff)

Places