File 0328-common_test-Remove-unnecessary-check-as-te... of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 0328-common_test-Remove-unnecessary-check-as-test-do-not-.patch of Package erlang (Revision ff8eff58e18c42004571f534c0dfeaef)

Currently displaying revision ff8eff58e18c42004571f534c0dfeaef , Show latest

From eff4778f79b0e7eefb508f01eb609316cb4af9ca Mon Sep 17 00:00:00 2001
From: Ingela Anderton Andin <ingela@erlang.org>
Date: Mon, 30 Aug 2021 13:58:46 +0200
Subject: [PATCH] common_test: Remove unnecessary check as test do not use
 OpenSSH

---
 .../netconfc1_SUITE.erl                       | 122 +++++++++---------
 .../netconfc_remote_SUITE.erl                 |   8 +-
 2 files changed, 59 insertions(+), 71 deletions(-)

diff --git a/lib/common_test/test/ct_netconfc_SUITE_data/netconfc1_SUITE.erl b/lib/common_test/test/ct_netconfc_SUITE_data/netconfc1_SUITE.erl
index 5610000bee..f36092713e 100644
--- a/lib/common_test/test/ct_netconfc_SUITE_data/netconfc1_SUITE.erl
+++ b/lib/common_test/test/ct_netconfc_SUITE_data/netconfc1_SUITE.erl
@@ -44,70 +44,64 @@ suite() ->
      }].
 
 all() ->
-    case os:find_executable("ssh") of
-	false ->
-	    {skip, "SSH not installed on host"};
-	_ ->
-	    [hello,
-	     hello_from_server_first,
-	     hello_named,
-	     hello_configured,
-	     hello_configured_extraopts,
-	     hello_required,
-	     hello_required_exists,
-	     hello_global_pwd,
-	     hello_no_session_id,
-	     hello_incomp_base_vsn,
-	     hello_no_base_cap,
-	     hello_no_caps,
-	     no_server_hello,
-	     no_client_hello,
-	     get_session_id,
-	     get_capabilities,
-	     faulty_user,
-	     faulty_passwd,
-	     faulty_port,
-	     no_host,
-	     no_port,
-	     invalid_opt,
-	     timeout_close_session,
-	     get,
-	     get_a_lot,
-	     timeout_get,
-	     flush_timeout_get,
-	     get_xpath,
-	     get_config,
-	     get_config_xpath,
-	     edit_config,
-	     edit_config_opt_params,
-	     copy_config,
-	     delete_config,
-	     lock,
-	     unlock,
-	     kill_session,
-	     get_no_such_client,
-	     action,
-	     send_any_rpc,
-	     send_any,
-	     hide_password,
-	     not_proper_xml,
-	     prefixed_namespace,
-	     receive_chunked_data,
-	     timeout_receive_chunked_data,
-	     close_while_waiting_for_chunked_data,
-	     connection_crash,
-	     get_event_streams,
-	     create_subscription,
-	     receive_one_event,
-             receive_two_events,
-	     receive_multiple_events,
-	     receive_event_and_rpc,
-	     receive_event_and_rpc_in_chunks,
-             multiple_channels,
-             kill_session_same_connection
-	    ]
-    end.
-
+    [hello,
+     hello_from_server_first,
+     hello_named,
+     hello_configured,
+     hello_configured_extraopts,
+     hello_required,
+     hello_required_exists,
+     hello_global_pwd,
+     hello_no_session_id,
+     hello_incomp_base_vsn,
+     hello_no_base_cap,
+     hello_no_caps,
+     no_server_hello,
+     no_client_hello,
+     get_session_id,
+     get_capabilities,
+     faulty_user,
+     faulty_passwd,
+     faulty_port,
+     no_host,
+     no_port,
+     invalid_opt,
+     timeout_close_session,
+     get,
+     get_a_lot,
+     timeout_get,
+     flush_timeout_get,
+     get_xpath,
+     get_config,
+     get_config_xpath,
+     edit_config,
+     edit_config_opt_params,
+     copy_config,
+     delete_config,
+     lock,
+     unlock,
+     kill_session,
+     get_no_such_client,
+     action,
+     send_any_rpc,
+     send_any,
+     hide_password,
+     not_proper_xml,
+     prefixed_namespace,
+     receive_chunked_data,
+     timeout_receive_chunked_data,
+     close_while_waiting_for_chunked_data,
+     connection_crash,
+     get_event_streams,
+     create_subscription,
+     receive_one_event,
+     receive_two_events,
+     receive_multiple_events,
+     receive_event_and_rpc,
+     receive_event_and_rpc_in_chunks,
+     multiple_channels,
+     kill_session_same_connection
+    ].
 
 groups() ->
     [].
diff --git a/lib/common_test/test/ct_netconfc_SUITE_data/netconfc_remote_SUITE.erl b/lib/common_test/test/ct_netconfc_SUITE_data/netconfc_remote_SUITE.erl
index cbdb4cf11a..15e4b2b00b 100644
--- a/lib/common_test/test/ct_netconfc_SUITE_data/netconfc_remote_SUITE.erl
+++ b/lib/common_test/test/ct_netconfc_SUITE_data/netconfc_remote_SUITE.erl
@@ -30,13 +30,7 @@ suite() ->
      {ct_hooks, [{cth_conn_log,[{ct_netconfc,[{log_type,html}]}]}]}].
 
 all() ->
-    case os:find_executable("ssh") of
-	false ->
-	    {skip, "SSH not installed on host"};
-	_ ->
-	    [remote_crash
-	    ]
-    end.
+    [remote_crash].
 
 groups() ->
     [].
-- 
2.31.1

Places

File 0328-common_test-Remove-unnecessary-check-as-test-do-not-.patch of Package erlang (Revision ff8eff58e18c42004571f534c0dfeaef)

Places