File 0339-megaco-test-Cleanup-of-the-examples-suite.... of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 0339-megaco-test-Cleanup-of-the-examples-suite.patch of Package erlang (Revision 3175af84015e911d0fac4e6fb9e3a360)

Currently displaying revision 3175af84015e911d0fac4e6fb9e3a360 , Show latest

From d06afae331796159c8b8c7279b03b80feba01aba Mon Sep 17 00:00:00 2001
From: Micael Karlberg <bmk@erlang.org>
Date: Fri, 4 Feb 2022 18:53:39 +0100
Subject: [PATCH 2/2] [megaco|test] Cleanup of the examples suite

OTP-17910
---
 lib/megaco/test/megaco_examples_SUITE.erl | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/lib/megaco/test/megaco_examples_SUITE.erl b/lib/megaco/test/megaco_examples_SUITE.erl
index dc3dfb7967..6c1df0d4ec 100644
--- a/lib/megaco/test/megaco_examples_SUITE.erl
+++ b/lib/megaco/test/megaco_examples_SUITE.erl
@@ -342,12 +342,16 @@ simple(suite) ->
     [];
 simple(Config) when is_list(Config) ->
     process_flag(trap_exit, true),
-    d("simple -> create node name(s)"),
-    [_Local, MGC, MG] = ?LIB:mk_nodes(3), %% Grrr
+
+    d("simple -> create (3) node name(s) (includes the own node)"),
+    %% We actually need two (nodes), but the function includes the own node,
+    %% so we need to ask for one more.
+    [_Local, MGC, MG] = ?MK_NODES(3),
     Nodes = [MGC, MG],
 
-    d("simple -> start nodes"),
-    ok = ?LIB:start_nodes(Nodes, ?MODULE, ?LINE),
+    d("simple -> start nodes: "
+      "~n      ~p", [Nodes]),
+    ok = ?START_NODES(Nodes, true),
     
     MGCId = "MGC",
     MGId  = "MG",
@@ -472,11 +476,9 @@ simple(Config) when is_list(Config) ->
 	    ok
     end,
 
-    d("simple -> stop ~p", [MGC]),
-    slave:stop(MGC),
-
-    d("simple -> stop ~p", [MG]),
-    slave:stop(MG),
+    d("simple -> stop nodes"
+      "~n      ~p", [Nodes]),
+    ?STOP_NODES(Nodes),
 
     d("simple -> done", []),
     ok.
-- 
2.34.1

Places

File 0339-megaco-test-Cleanup-of-the-examples-suite.patch of Package erlang (Revision 3175af84015e911d0fac4e6fb9e3a360)

Places