File 0476-megaco-test-Adjust-error-report-function.p... of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 0476-megaco-test-Adjust-error-report-function.patch of Package erlang (Revision 141dc5cf1cf76598898fdde76784937f)

Currently displaying revision 141dc5cf1cf76598898fdde76784937f , Show latest

From 8d3e34316e253681fc012bf18cee9be5809ead8a Mon Sep 17 00:00:00 2001
From: Micael Karlberg <bmk@erlang.org>
Date: Mon, 29 Aug 2022 18:15:06 +0200
Subject: [PATCH 2/3] [megaco|test] Adjust error report function

"Magically" wrap'ed error in such a way that the
test wrapper themselves did not detect that an error
had occured (and therefor could not do checks).
---
 lib/megaco/test/megaco_test_lib.erl | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/lib/megaco/test/megaco_test_lib.erl b/lib/megaco/test/megaco_test_lib.erl
index 2937ff4da9..145a9b9920 100644
--- a/lib/megaco/test/megaco_test_lib.erl
+++ b/lib/megaco/test/megaco_test_lib.erl
@@ -78,7 +78,7 @@
 
 -include("megaco_test_lib.hrl").
 
--record('REASON', {mod, line, desc}).
+%% -record('REASON', {mod, line, desc}).
 
 
 %% ----------------------------------------------------------------
@@ -364,19 +364,11 @@ display_system_info(WhenStr, ModFuncStr) ->
 %% Stores the result in the process dictionary if mismatch
 
 error(Actual, Mod, Line) ->
-    global:send(megaco_global_logger, {failed, Mod, Line}),
     log("<ERROR> Bad result: ~p~n", [Actual], Mod, Line),
     Label = lists:concat([Mod, "(", Line, ") unexpected result"]),
     megaco:report_event(60, Mod, Mod, Label,
 			[{line, Mod, Line}, {error, Actual}]),
-    case global:whereis_name(megaco_test_case_sup) of
-	undefined -> 
-	    ignore;
-	Pid -> 
-	    Fail = #'REASON'{mod = Mod, line = Line, desc = Actual},
-	    Pid ! {fail, self(), Fail}
-    end,
-    Actual.
+    exit(Actual).
 
 log(Format, Args, Mod, Line) ->
     case global:whereis_name(megaco_global_logger) of
-- 
2.35.3

Places

File 0476-megaco-test-Adjust-error-report-function.patch of Package erlang (Revision 141dc5cf1cf76598898fdde76784937f)

Places