File 0881-Fix-for-Werror-format-security.patch of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 0881-Fix-for-Werror-format-security.patch of Package erlang (Revision 3175af84015e911d0fac4e6fb9e3a360)

Currently displaying revision 3175af84015e911d0fac4e6fb9e3a360 , Show latest

From a18e1c688242a4afe03d46337a94607bdeffa517 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jo=C3=A3o=20Henrique=20Ferreira=20de=20Freitas?=
 <joaohf@gmail.com>
Date: Thu, 26 Oct 2023 21:13:39 -0300
Subject: [PATCH] Fix for -Werror=format-security

Have to pass either a string literal or format string to sprintf() when
compiling with -Wformat -Wformat-security -Werror=format-security flags

| In file included from sys_info_base_drv.c:84:
| sys_info_drv_impl.c: In function 'control':
| sys_info_drv_impl.c:145:9: error: format not a string literal and no
format arguments [-Werror=format-security]
|   145 |         res = sprintf(str, beyond_end_format);
|       |         ^~~
| sys_info_drv_impl.c:150:13: error: format not a string literal and no
format arguments [-Werror=format-security]
|   150 |             res = sprintf(str, buf_overflow_format);
|       |             ^~~
| cc1: some warnings being treated as errors
| make: *** [Makefile:51: sys_info_base_drv.so] Error 1
| Runtime terminating during boot ({make_failed,make})
|
| Crash dump is being written to: erl_crash.dump...done
| WARNING: exit code 1 from a shell command.
---
 erts/emulator/test/driver_SUITE_data/sys_info_drv_impl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/erts/emulator/test/driver_SUITE_data/sys_info_drv_impl.c b/erts/emulator/test/driver_SUITE_data/sys_info_drv_impl.c
index 7c22e2c365..6639d67105 100644
--- a/erts/emulator/test/driver_SUITE_data/sys_info_drv_impl.c
+++ b/erts/emulator/test/driver_SUITE_data/sys_info_drv_impl.c
@@ -142,12 +142,12 @@ control(ErlDrvData drv_data,
     if (memcmp(((char *) sip) + ERL_DRV_SYS_INFO_SIZE,
 	       (char *) &deadbeef[0],
 	       sizeof(deadbeef)) != 0) {
-	res = sprintf(str, beyond_end_format);
+	res = sprintf(str, "%s", beyond_end_format);
     }
     else {
 	res = sys_info_drv_sprintf_sys_info(sip, str);
 	if (res > slen)
-	    res = sprintf(str, buf_overflow_format);
+	    res = sprintf(str, "%s", buf_overflow_format);
     }
     driver_free(sip);
     return res;
-- 
2.35.3

Places

File 0881-Fix-for-Werror-format-security.patch of Package erlang (Revision 3175af84015e911d0fac4e6fb9e3a360)

Places