File 1050-erts-Fix-bug-in-concurrent-crash-dumping.p... of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 1050-erts-Fix-bug-in-concurrent-crash-dumping.patch of Package erlang (Revision 58ddfd9fcf4c281c82656d8c2d2a71df)

Currently displaying revision 58ddfd9fcf4c281c82656d8c2d2a71df , Show latest

From d9c463d85f1b0ba52bb4192b769f11505e15fb83 Mon Sep 17 00:00:00 2001
From: Sverker Eriksson <sverker@erlang.org>
Date: Tue, 18 Jun 2024 14:51:54 +0200
Subject: [PATCH 2/2] erts: Fix bug in concurrent crash dumping

If two or more threads race to crash dump one should succeed
and the others should block in erts_thr_progress_fatal_error_block().

Just returning makes no sense.
---
 erts/emulator/beam/break.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/erts/emulator/beam/break.c b/erts/emulator/beam/break.c
index 3b6de45587..8e13844a99 100644
--- a/erts/emulator/beam/break.c
+++ b/erts/emulator/beam/break.c
@@ -805,9 +805,6 @@ erl_crash_dump_v(char *file, int line, const char* fmt, va_list args)
     LimitedWriterInfo lwi;
     static char* write_buffer;  /* 'static' to avoid a leak warning in valgrind */
 
-    if (ERTS_SOMEONE_IS_CRASH_DUMPING)
-	return;
-
     /* Order all managed threads to block, this has to be done
        first to guarantee that this is the only thread to generate
        crash dump. */
-- 
2.35.3

Places

File 1050-erts-Fix-bug-in-concurrent-crash-dumping.patch of Package erlang (Revision 58ddfd9fcf4c281c82656d8c2d2a71df)

Places