File 1055-observer-test-Tweaked-crashdump-viewer-sta... of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 1055-observer-test-Tweaked-crashdump-viewer-start-stop-te.patch of Package erlang (Revision 937f847f2956692f80dfc36d9f9dc085)

Currently displaying revision 937f847f2956692f80dfc36d9f9dc085 , Show latest

From e813fe5e57c0da5359a79b933de5266d35432c8c Mon Sep 17 00:00:00 2001
From: Micael Karlberg <bmk@erlang.org>
Date: Wed, 19 May 2021 14:06:01 +0200
Subject: [PATCH 15/17] [observer|test] Tweaked crashdump-viewer start-stop
 test case

This test case core-dumps on OpenIndiana, so add some printouts
to better display progress...
---
 lib/observer/test/crashdump_viewer_SUITE.erl | 30 ++++++++++++++------
 1 file changed, 21 insertions(+), 9 deletions(-)

diff --git a/lib/observer/test/crashdump_viewer_SUITE.erl b/lib/observer/test/crashdump_viewer_SUITE.erl
index 2a223a33f6..05fde1f22e 100644
--- a/lib/observer/test/crashdump_viewer_SUITE.erl
+++ b/lib/observer/test/crashdump_viewer_SUITE.erl
@@ -152,29 +152,41 @@ start_stop(Config) when is_list(Config) ->
     ct:log("CDV procs: ~n~p~n",[Regs]),
     [true=is_pid(P) || {P,_,_} <- Regs],
     timer:sleep(5000), % give some time to live
+    ct:log("try stop crashdump viewer (async)~n"),
     ok = crashdump_viewer:stop(),
+    ct:log("await crashdump viewer processes termination~n"),
     recv_downs(Regs),
+    ct:log("sleep some~n"),
     timer:sleep(2000),
+    ct:log("try get all processes~n"),
     ProcsAfter = processes(),
     NumProcsAfter = length(ProcsAfter),
-    if NumProcsAfter=/=NumProcsBefore ->
-	    ct:log("Before but not after:~n~p~n",
-		   [[{P,process_info(P)} || P <- ProcsBefore -- ProcsAfter]]),
-	    ct:log("After but not before:~n~p~n",
-		   [[{P,process_info(P)} || P <- ProcsAfter -- ProcsBefore]]),
-	    ct:fail("leaking processes");
+    ct:log("try verify crashdump viewer stopped~n"),
+    if (NumProcsAfter =/= NumProcsBefore) ->
+	    ct:log("Leaking processes: "
+                   "~n   Before but not after:"
+                   "~n      ~p"
+                   "~n   After but not before:"
+                   "~n      ~p",
+		   [
+                    [{P,process_info(P)} || P <- ProcsBefore -- ProcsAfter],
+                    [{P,process_info(P)} || P <- ProcsAfter -- ProcsBefore]
+                   ]);
        true ->
 	    ok
     end,
     ok.
 
 recv_downs([]) ->
+    ct:log("'DOWN' received from all registered proceses~n", []),
     ok;
 recv_downs(Regs) ->
     receive
-	{'DOWN',Ref,process,_Pid,_} ->
-	    ct:log("Got 'DOWN' for process ~n~p~n",[_Pid]),
-	    recv_downs(lists:keydelete(Ref,3,Regs))
+	{'DOWN', Ref, process, _Pid, _} ->
+            Regs2 = lists:keydelete(Ref, 3, Regs),
+	    ct:log("Got 'DOWN' for process ~p (~w procs remaining)~n",
+                   [_Pid, length(Regs2)]),
+	    recv_downs(Regs2)
     after 30000 ->
 	    ct:log("Timeout waiting for down:~n~p~n",
 		   [[{Reg,process_info(P)} || {P,_,_}=Reg <- Regs]]),
-- 
2.26.2

Places

File 1055-observer-test-Tweaked-crashdump-viewer-start-stop-te.patch of Package erlang (Revision 937f847f2956692f80dfc36d9f9dc085)

Places