File 1110-asmjit-Correct-assembly-of-mov-instruction... of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 1110-asmjit-Correct-assembly-of-mov-instruction.patch of Package erlang (Revision 63a1bfb33d7f4fc528be33fc9d548213)

Currently displaying revision 63a1bfb33d7f4fc528be33fc9d548213 , Show latest

From d2484d11877569ee64ac02618a038b4bffb82ee3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Mon, 10 May 2021 07:26:21 +0200
Subject: [PATCH 10/20] asmjit: Correct assembly of mov instruction

No instruction would be emitted by the following code:

a.mov(a64::x0, imm(-1))

For other literals, MOVK instructions could be emitted, but the
initial MOVZ or MOVN instruction would be missing.

https://github.com/asmjit/asmjit/issues/335
---
 erts/emulator/asmjit/arm/a64assembler.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/erts/emulator/asmjit/arm/a64assembler.cpp b/erts/emulator/asmjit/arm/a64assembler.cpp
index 3d57eaaf1a..1cd17d89d5 100644
--- a/erts/emulator/asmjit/arm/a64assembler.cpp
+++ b/erts/emulator/asmjit/arm/a64assembler.cpp
@@ -357,7 +357,7 @@ static uint32_t encodeMovSequence64(uint32_t out[4], uint64_t imm, uint32_t rd)
 
     for (uint32_t hwIndex = 0; hwIndex < 4; hwIndex++, imm >>= 16) {
       uint32_t hwImm = uint32_t(imm & 0xFFFFu);
-      if (hwImm == 0)
+      if (hwImm == 0 && hwIndex != 0)
         continue;
 
       out[count++] = op | (hwIndex << 21) | (hwImm << 5) | rd;
@@ -373,7 +373,7 @@ static uint32_t encodeMovSequence64(uint32_t out[4], uint64_t imm, uint32_t rd)
 
     for (uint32_t hwIndex = 0; hwIndex < 4; hwIndex++, imm >>= 16) {
       uint32_t hwImm = uint32_t(imm & 0xFFFFu);
-      if (hwImm == 0xFFFFu)
+      if (hwImm == 0xFFFFu && hwIndex != 0)
         continue;
 
       out[count++] = op | (hwIndex << 21) | ((hwImm ^ negMask) << 5) | rd;
-- 
2.26.2

Places

File 1110-asmjit-Correct-assembly-of-mov-instruction.patch of Package erlang (Revision 63a1bfb33d7f4fc528be33fc9d548213)

Places