File 1116-jit-Resolve-a-vestigial-FIXME.patch of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 1116-jit-Resolve-a-vestigial-FIXME.patch of Package erlang (Revision 51223dbfed63638bb2cfdc0d435b5ce4)

Currently displaying revision 51223dbfed63638bb2cfdc0d435b5ce4 , Show latest

From ec82c7325cfd135f3d7f76f61abdb86fec027792 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?John=20H=C3=B6gberg?= <john@erlang.org>
Date: Tue, 11 May 2021 09:49:57 +0200
Subject: [PATCH 16/20] jit: Resolve a vestigial FIXME

---
 erts/emulator/beam/jit/x86/instr_bif.cpp | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/erts/emulator/beam/jit/x86/instr_bif.cpp b/erts/emulator/beam/jit/x86/instr_bif.cpp
index bc1d7c33b9..b9316f8dc7 100644
--- a/erts/emulator/beam/jit/x86/instr_bif.cpp
+++ b/erts/emulator/beam/jit/x86/instr_bif.cpp
@@ -658,9 +658,8 @@ void BeamModuleAssembler::emit_send() {
     Label entry = a.newLabel();
 
     /* This is essentially a mirror of call_light_bif, there's no point to
-     * specializing send/2 anymore.
-     *
-     * FIXME: Rewrite this to an ordinary BIF in the loader instead. */
+     * specializing send/2 anymore. We do it here because it's far more work to
+     * do it in the loader. */
     align_erlang_cp();
     a.bind(entry);
 
-- 
2.26.2

Places

File 1116-jit-Resolve-a-vestigial-FIXME.patch of Package erlang (Revision 51223dbfed63638bb2cfdc0d435b5ce4)

Places