File 1171-Fix-race-related-to-precompiled-header-dur... of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 1171-Fix-race-related-to-precompiled-header-during-compil.patch of Package erlang (Revision afcf17dce72e3ad97ec30c595b0394c3)

Currently displaying revision afcf17dce72e3ad97ec30c595b0394c3 , Show latest

From 04f0aa11e9d47736e5425c4d2cc1f3dd77eda630 Mon Sep 17 00:00:00 2001
From: Frej Drejhammar <frej.drejhammar@gmail.com>
Date: Thu, 7 Oct 2021 10:50:28 +0200
Subject: [PATCH] Fix race related to precompiled header during compilation

Files matching `erts/emulator/beam/jit/$(JIT_ARCH)/%.cpp` are compiled
with the command line flag `-include $(ASMJIT_PCH_SRC)`, but as there
is no dependency on `$(ASMJIT_PCH_OBJ)` the compilation of the C++
module will race with the precompilation of `$(ASMJIT_PCH_SRC)`. The
missing dependency leads to intermittent build failures as g++ will,
when reading an incomplete precompiled header, abort with `cc1plus:
error: while reading precompiled header: No such file or directory`.

Avoid this race by adding a dependency on `$(ASMJIT_PCH_OBJ)` just as
for files matching `erts/emulator/beam/jit/%.cpp` and
`erts/emulator/asmjit/%.cpp`.
---
 erts/emulator/Makefile.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/erts/emulator/Makefile.in b/erts/emulator/Makefile.in
index 4a973f8ba2..51b81e4d82 100644
--- a/erts/emulator/Makefile.in
+++ b/erts/emulator/Makefile.in
@@ -930,7 +930,8 @@ $(OBJDIR)/%.o: beam/jit/%.cpp $(ASMJIT_PCH_OBJ)
           $(subst -O2, $(GEN_OPT_FLGS), $(CXXFLAGS))                \
           -include $(ASMJIT_PCH_SRC) -c $< -o $@
 
-$(OBJDIR)/%.o: beam/jit/$(JIT_ARCH)/%.cpp beam/jit/$(JIT_ARCH)/beam_asm.hpp
+$(OBJDIR)/%.o: beam/jit/$(JIT_ARCH)/%.cpp beam/jit/$(JIT_ARCH)/beam_asm.hpp \
+	$(ASMJIT_PCH_OBJ)
 	$(V_CXX) $(ASMJIT_FLAGS) $(INCLUDES)                            \
           $(subst -O2, $(GEN_OPT_FLGS), $(CXXFLAGS))                \
           -include $(ASMJIT_PCH_SRC) -c $< -o $@
-- 
2.31.1

Places

File 1171-Fix-race-related-to-precompiled-header-during-compil.patch of Package erlang (Revision afcf17dce72e3ad97ec30c595b0394c3)

Places