File 2421-Remove-unused-erl_eval-code.patch of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 2421-Remove-unused-erl_eval-code.patch of Package erlang (Revision a348a67ba66c7a948f8268ea2bae17d0)

Currently displaying revision a348a67ba66c7a948f8268ea2bae17d0 , Show latest

From 3df8eb4c175d4016ea408bd7f130bbdec87cbb1d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20Valim?= <jose.valim@dashbit.co>
Date: Tue, 4 Jan 2022 09:54:13 +0100
Subject: [PATCH] Remove unused erl_eval code

* {value, Value, Binding} was an implicit contract
    with shell that is no longer used

* Both record and tuple calls have been deprecated
    and removed for quite some time
---
 lib/stdlib/src/erl_eval.erl | 23 ++++-------------------
 1 file changed, 4 insertions(+), 19 deletions(-)

diff --git a/lib/stdlib/src/erl_eval.erl b/lib/stdlib/src/erl_eval.erl
index 135d2713e7..7a809c4402 100644
--- a/lib/stdlib/src/erl_eval.erl
+++ b/lib/stdlib/src/erl_eval.erl
@@ -501,9 +501,7 @@ expr({bin,_,Fs}, Bs0, Lf, Ef, RBs, FUVs) ->
     {value,V,Bs} = eval_bits:expr_grp(Fs, Bs0, EvalFun),
     ret_expr(V, Bs, RBs);
 expr({remote,_,_,_}, _Bs, _Lf, _Ef, _RBs, _FUVs) ->
-    erlang:raise(error, {badexpr,':'}, ?STACKTRACE);
-expr({value,_,Val}, Bs, _Lf, _Ef, RBs, _FUVs) ->    % Special case straight values.
-    ret_expr(Val, Bs, RBs).
+    erlang:raise(error, {badexpr,':'}, ?STACKTRACE).
 
 find_maxline(LC) ->
     put('$erl_eval_max_line', 0),
@@ -636,24 +634,11 @@ bif(apply, [F,As], Bs, Ef, RBs) ->
 bif(Name, As, Bs, Ef, RBs) ->
     do_apply(erlang, Name, As, Bs, Ef, RBs).
 
-%% do_apply(MF, Arguments, Bindings, ExternalFuncHandler, RBs) ->
+%% do_apply(Func, Arguments, Bindings, ExternalFuncHandler, RBs) ->
 %%	{value,Value,Bindings} | Value when
-%%	ExternalFuncHandler = {value,F} | none.
-%% MF is a tuple {Module,Function} or a fun.
+%%	ExternalFuncHandler = {value,F} | none,
+%%  Func = fun()
 
-do_apply({M,F}=Func, As, Bs0, Ef, RBs)
-  when tuple_size(M) >= 1, is_atom(element(1, M)), is_atom(F) ->
-    case Ef of
-        none when RBs =:= value ->
-            %% Make tail recursive calls when possible.
-            apply(M, F, As);
-        none ->
-            ret_expr(apply(M, F, As), Bs0, RBs);
-        {value,Fun} when RBs =:= value ->
-            Fun(Func, As);
-        {value,Fun} ->
-            ret_expr(Fun(Func, As), Bs0, RBs)
-    end;
 do_apply(Func, As, Bs0, Ef, RBs) ->
     Env = if
               is_function(Func) ->
-- 
2.31.1

Places

File 2421-Remove-unused-erl_eval-code.patch of Package erlang (Revision a348a67ba66c7a948f8268ea2bae17d0)

Places