File 3891-ssl-Remove-hardcoded-test.patch of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 3891-ssl-Remove-hardcoded-test.patch of Package erlang (Revision 306b0d872de0b3cd91c16cc44321c73e)

Currently displaying revision 306b0d872de0b3cd91c16cc44321c73e , Show latest

From 1811b60b10e0b659187e47ad61b12d404c6ab4b9 Mon Sep 17 00:00:00 2001
From: Ingela Anderton Andin <ingela@erlang.org>
Date: Mon, 30 Jan 2023 09:05:22 +0100
Subject: [PATCH] ssl: Remove hardcoded test

Encoding of srp extension is tested by the property testing and
this test has stop working as it assumes orders of maps, that you
can not depend on.
---
 lib/ssl/test/ssl_handshake_SUITE.erl | 30 ++--------------------------
 1 file changed, 2 insertions(+), 28 deletions(-)

diff --git a/lib/ssl/test/ssl_handshake_SUITE.erl b/lib/ssl/test/ssl_handshake_SUITE.erl
index 1bde66a80b..9612a5ecb6 100644
--- a/lib/ssl/test/ssl_handshake_SUITE.erl
+++ b/lib/ssl/test/ssl_handshake_SUITE.erl
@@ -52,8 +52,7 @@
          decode_empty_server_sni_correctly/1,
          select_proper_tls_1_2_rsa_default_hashsign/1,
          ignore_hassign_extension_pre_tls_1_2/1,
-         signature_algorithms/1,
-         encode_decode_srp/1]).
+         signature_algorithms/1]).
 
 %%--------------------------------------------------------------------
 %% Common Test interface functions -----------------------------------
@@ -67,8 +66,7 @@ all() -> [decode_hello_handshake,
 	  decode_empty_server_sni_correctly,
 	  select_proper_tls_1_2_rsa_default_hashsign,
 	  ignore_hassign_extension_pre_tls_1_2,
-	  signature_algorithms,
-	  encode_decode_srp].
+	  signature_algorithms].
 
 %%--------------------------------------------------------------------
 init_per_suite(Config) ->
@@ -198,30 +196,6 @@ ignore_hassign_extension_pre_tls_1_2(Config) ->
     {md5sha, rsa} = ssl_handshake:select_hashsign({HashSigns, undefined}, Cert, ecdhe_rsa, tls_v1:default_signature_algs([{3,2}]), {3,2}),
     {md5sha, rsa} = ssl_handshake:select_hashsign({HashSigns, undefined}, Cert, ecdhe_rsa, tls_v1:default_signature_algs([{3,0}]), {3,0}).
 
-encode_decode_srp(_Config) ->
-    Exts = #{srp => #srp{username = <<"foo">>},
-             sni => #sni{hostname = "bar"},
-             renegotiation_info => undefined,
-             signature_algs => undefined,
-             alpn => undefined,
-             next_protocol_negotiation => undefined,
-             ec_point_formats => undefined,
-             elliptic_curves => undefined
-            },
-    EncodedExts0 = <<0,20,          % Length
-                    0,12,          % SRP extension
-                    0,4,           % Length
-                    3,             % srp_I length
-                    102,111,111, % username = "foo"
-                    0,0,           % SNI extension
-                    0,8,           % Length
-                    0,6,           % ServerNameLength
-                    0,             % NameType (host_name)
-                    0,3,           % HostNameLength
-                    98,97,114>>,     % hostname = "bar"
-    EncodedExts0 = <<?UINT16(_),EncodedExts/binary>> =
-        ssl_handshake:encode_hello_extensions(Exts, {3,3}),
-    Exts = ssl_handshake:decode_hello_extensions(EncodedExts, {3,3}, {3,3}, client).
 
 signature_algorithms(Config) ->
     Opts = proplists:get_value(server_opts, Config),
-- 
2.35.3

Places

File 3891-ssl-Remove-hardcoded-test.patch of Package erlang (Revision 306b0d872de0b3cd91c16cc44321c73e)

Places