File 5310-Reorder-tests-and-try-to-fix-blocking-test... of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 5310-Reorder-tests-and-try-to-fix-blocking-test.patch of Package erlang (Revision 1fc7c4a65d33ed71e140bb0aefb4cd4d)

Currently displaying revision 1fc7c4a65d33ed71e140bb0aefb4cd4d , Show latest

From 5f41a3988ba7391faf8377a1d86512a6c947c213 Mon Sep 17 00:00:00 2001
From: Benedikt Reinartz <filmor@gmail.com>
Date: Tue, 17 Jan 2023 20:10:58 +0100
Subject: [PATCH 10/12] Reorder tests and try to fix blocking test

---
 lib/observer/test/observer_SUITE.erl | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/lib/observer/test/observer_SUITE.erl b/lib/observer/test/observer_SUITE.erl
index c572a7a331..daa7dc8724 100644
--- a/lib/observer/test/observer_SUITE.erl
+++ b/lib/observer/test/observer_SUITE.erl
@@ -60,8 +60,8 @@ groups() ->
        process_win,
        table_win,
        port_win_when_tab_not_initiated,
-       remote_node,
-       blocking_start
+       blocking_start,
+       remote_node
       ]
      }].
 
@@ -480,11 +480,14 @@ remote_node(_Config) ->
     peer:stop(Peer).
 
 blocking_start(_Config) ->
-    _Pid = spawn(fun observer:start_and_wait/0),
-    MonitorRef = monitor(process, observer),
+    Pid = spawn(fun observer:start_and_wait/0),
+    SpawnerRef = monitor(process, Pid),
+    ObserverRef = monitor(process, observer),
     receive
-        {'DOWN', MonitorRef, _, _, _} ->
-            error(observer_stopped_unexpectedly)
+        {'DOWN', ObserverRef, _, _, _} ->
+            error(observer_stopped_unexpectedly);
+        {'DOWN', SpawnerRef, _, _, _} ->
+            error(spawner_stopped_unexpectedly)
     after
         500 ->
             ok
@@ -492,12 +495,14 @@ blocking_start(_Config) ->
     observer:stop(),
     ensure_observer_stopped(),
     receive
-        {'DOWN', MonitorRef, _, _, _} ->
+        {'DOWN', ObserverRef, _, _, _} ->
             ok
     after
         500 ->
             error(observer_should_have_stopped)
-    end.
+    end,
+    false = erlang:is_process_alive(Pid),
+    ok.
 
 %% Test PR-1296/OTP-14151
 %% Clicking a link to a port before the port tab has been activated the
-- 
2.35.3

Places

File 5310-Reorder-tests-and-try-to-fix-blocking-test.patch of Package erlang (Revision 1fc7c4a65d33ed71e140bb0aefb4cd4d)

Places