File 5971-xref-drop-unused-code.patch of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 5971-xref-drop-unused-code.patch of Package erlang (Revision c667b5069ef18e7eb4954e8113ac1037)

Currently displaying revision c667b5069ef18e7eb4954e8113ac1037 , Show latest

From 1697c829a3aff5fd5251d4e5a191a6608aea65f0 Mon Sep 17 00:00:00 2001
From: Maxim Fedorov <maximfca@gmail.com>
Date: Tue, 21 Mar 2023 10:18:10 -0700
Subject: [PATCH] [xref] drop unused code

This code does nothing.

Reported by @mmin on the Erlang Forums,
https://erlangforums.com/t/wondering-why-we-need-the-last-expression-in-this-code-from-xref-reader-erl/2482
---
 lib/tools/src/xref_reader.erl | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/lib/tools/src/xref_reader.erl b/lib/tools/src/xref_reader.erl
index 383bb5e8d3..09132d0f5b 100644
--- a/lib/tools/src/xref_reader.erl
+++ b/lib/tools/src/xref_reader.erl
@@ -77,10 +77,6 @@ forms([], S) ->
              F ->
                  [{M, F, 0}]
          end,
-    #xrefr{def_at = DefAt,
-	   l_call_at = LCallAt, x_call_at = XCallAt,
-	   el = LC, ex = XC, x = X, df = Depr, on_load = OnLoad,
-	   lattrs = AL, xattrs = AX, battrs = B, unresolved = U} = S,
     Attrs = {lists:reverse(AL), lists:reverse(AX), lists:reverse(B)},
     {ok, M, {DefAt, LCallAt, XCallAt, LC, XC, X, Attrs, Depr, OL}, U}.
 
-- 
2.35.3

Places

File 5971-xref-drop-unused-code.patch of Package erlang (Revision c667b5069ef18e7eb4954e8113ac1037)

Places