File 0001-DeviceNotifications-Keep-last-message-for-... of Package plasma5-workspace

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-DeviceNotifications-Keep-last-message-for-each-devic.patch of Package plasma5-workspace (Revision f37130e65a1ea91beb6cd734c4c2a6ce)

Currently displaying revision f37130e65a1ea91beb6cd734c4c2a6ce , Show latest

From 4eb609ec64069d982627948918f8044e803e5ed4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Br=C3=BCns?= <stefan.bruens@rwth-aachen.de>
Date: Sat, 6 Jul 2019 20:28:30 +0200
Subject: [PATCH] [DeviceNotifications] Keep last message for each device

Ejecting e.g. a USB stick removes it from the bus (bus power is removed),
but the last notification should be kept, otherwise a message like
"The device can be savely removed" immediately disappears.

Unfortunately it is almost impossible to tell when a device has been
physically removed (only indirectly, when a new device is plugged into
the same port), so allow some small leakage - in case the same device is
later replugged, no leakage happens.
---
 dataengines/devicenotifications/ksolidnotify.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/dataengines/devicenotifications/ksolidnotify.cpp b/dataengines/devicenotifications/ksolidnotify.cpp
index 8b28d620..07e894e9 100644
--- a/dataengines/devicenotifications/ksolidnotify.cpp
+++ b/dataengines/devicenotifications/ksolidnotify.cpp
@@ -58,6 +58,8 @@ KSolidNotify::KSolidNotify(QObject *parent):
 
 void KSolidNotify::onDeviceAdded(const QString &udi)
 {
+    // Clear any stale message from a previous instance
+    emit clearNotification(udi);
     Solid::Device device(udi);
     m_devices.insert(udi, device);
     connectSignals(&m_devices[udi]);
@@ -72,7 +74,6 @@ void KSolidNotify::onDeviceRemoved(const QString &udi)
         }
     }
     m_devices.remove(udi);
-    emit clearNotification(udi);
 }
 
 bool KSolidNotify::isSafelyRemovable(const QString &udi) const
-- 
2.22.0

Places

File 0001-DeviceNotifications-Keep-last-message-for-each-devic.patch of Package plasma5-workspace (Revision f37130e65a1ea91beb6cd734c4c2a6ce)

Places