File 0002-Bookmarks-Runner-Avoid-leaking-FetchSqlite... of Package plasma5-workspace

Overview Repositories Revisions Requests Users Attributes Meta

File 0002-Bookmarks-Runner-Avoid-leaking-FetchSqlite-instances.patch of Package plasma5-workspace (Revision e708fd90268cb6dd9084d6b481f1b801)

Currently displaying revision e708fd90268cb6dd9084d6b481f1b801 , Show latest

From d86b5efce44f6cde9e78c9832b57ec36c72564ff Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Br=C3=BCns?= <stefan.bruens@rwth-aachen.de>
Date: Thu, 6 Sep 2018 05:12:30 +0200
Subject: [PATCH 2/2] [Bookmarks Runner] Avoid leaking FetchSqlite instances

The favicon and places instances are created in the prepare() call,
leaking the instance from the last invocation. Delete the old
instance in teardown().
---
 runners/bookmarks/browsers/firefox.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/runners/bookmarks/browsers/firefox.cpp b/runners/bookmarks/browsers/firefox.cpp
index 8a9aacda..7bd582cb 100644
--- a/runners/bookmarks/browsers/firefox.cpp
+++ b/runners/bookmarks/browsers/firefox.cpp
@@ -146,9 +146,13 @@ void Firefox::teardown()
 {
     if(m_fetchsqlite) {
         m_fetchsqlite->teardown();
+        delete m_fetchsqlite;
+        m_fetchsqlite = nullptr;
     }
     if(m_fetchsqlite_fav) {
         m_fetchsqlite_fav->teardown();
+        delete m_fetchsqlite_fav;
+        m_fetchsqlite_fav = nullptr;
         delete m_favicon;
         m_favicon = nullptr;
     }
-- 
2.19.0

Places

File 0002-Bookmarks-Runner-Avoid-leaking-FetchSqlite-instances.patch of Package plasma5-workspace (Revision e708fd90268cb6dd9084d6b481f1b801)

Places