File vita3k-PR2658.patch of Package vita3k

Overview Repositories Revisions Requests Users Attributes Meta

File vita3k-PR2658.patch of Package vita3k (Revision cef130c1ceea458c5c5287f0152be334)

Currently displaying revision cef130c1ceea458c5c5287f0152be334 , Show latest

From 71cd85e6cf6249ae050a91cae58828fdc57f191b Mon Sep 17 00:00:00 2001
From: Macdu <Macdu@users.noreply.github.com>
Date: Sun, 18 Jun 2023 18:16:31 +0200
Subject: [PATCH] renderer: Apply surface sync before signaling notifications

---
 vita3k/renderer/src/scene.cpp | 25 +++++++++++++++++++++----
 1 file changed, 21 insertions(+), 4 deletions(-)

diff --git a/vita3k/renderer/src/scene.cpp b/vita3k/renderer/src/scene.cpp
index 936327a2c5..7a7cbed9bc 100644
--- a/vita3k/renderer/src/scene.cpp
+++ b/vita3k/renderer/src/scene.cpp
@@ -94,9 +94,16 @@ COMMAND(handle_sync_surface_data) {
 
     const SceGxmNotification vertex_notification = helper.pop<SceGxmNotification>();
     const SceGxmNotification fragment_notification = helper.pop<SceGxmNotification>();
+    // with memory mapping, notifications are signaled another way
+    // also don't try to signal if there are no notifications
+    bool were_notifications_signaled = renderer.features.support_memory_mapping
+        || (!vertex_notification.address && !fragment_notification.address);
 
-    if ((vertex_notification.address || fragment_notification.address)
-        && !renderer.features.support_memory_mapping) {
+    auto signal_notifications = [&]() {
+        if (were_notifications_signaled)
+            return;
+
+        were_notifications_signaled = true;
         // signal the notification now
         std::unique_lock<std::mutex> lock(renderer.notification_mutex);
 
@@ -108,9 +115,14 @@ COMMAND(handle_sync_surface_data) {
         // unlocking before a notify should be faster
         lock.unlock();
         renderer.notification_ready.notify_all();
-    }
+    };
+
+    if (renderer.disable_surface_sync)
+        // do it as soon as possible
+        signal_notifications();
 
     if (renderer.current_backend == Backend::Vulkan) {
+        ;
         // TODO: put this in a function
         vulkan::VKContext *context = reinterpret_cast<vulkan::VKContext *>(renderer.context);
         if (context->is_recording)
@@ -121,14 +133,17 @@ COMMAND(handle_sync_surface_data) {
     if (helper.cmd->status) {
         surface = helper.pop<SceGxmColorSurface *>();
         if (!surface) {
+            signal_notifications();
             complete_command(renderer, helper, 1);
             return;
         }
     }
 
     if (renderer.disable_surface_sync || renderer.current_backend == Backend::Vulkan) {
-        if (helper.cmd->status)
+        if (helper.cmd->status) {
             complete_command(renderer, helper, 0);
+        }
+        signal_notifications();
         return;
     }
 
@@ -186,6 +201,8 @@ COMMAND(handle_sync_surface_data) {
     if (helper.cmd->status) {
         complete_command(renderer, helper, 0);
     }
+
+    signal_notifications();
 }
 
 COMMAND(handle_draw) {

Places

File vita3k-PR2658.patch of Package vita3k (Revision cef130c1ceea458c5c5287f0152be334)

Places