File check-for-missing-substitution.patch of Package container-build-checks

Overview Repositories Revisions Requests Users Attributes Meta

File check-for-missing-substitution.patch of Package container-build-checks (Revision c837d8795e689e44040b38717f30a27c)

Currently displaying revision c837d8795e689e44040b38717f30a27c , Show latest

From 12c33741e80cf7af7389b543bd8f2ed6e97844da Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dirk=20M=C3=BCller?= <dirk@dmllr.de>
Date: Thu, 8 Aug 2024 10:23:44 +0200
Subject: [PATCH] Reject labels that are missing a substitution

---
 container-build-checks.py | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/container-build-checks.py b/container-build-checks.py
index 4f6f2fe..b8c873c 100755
--- a/container-build-checks.py
+++ b/container-build-checks.py
@@ -71,6 +71,9 @@ def verify_disturl(image, result, value):
 # Split a reference (e.g. registry.opensuse.org/foo/bar:tag01) into (registry, repo, tag)
 REFERENCE_RE = re.compile("([^/]+)/([^:]+):([^:]+)")
 
+# Search for substitution patterns like %FOO% in label values
+LABEL_SUB_RE = re.compile("%([A-Za-z0-9_]+)%")
+
 
 def verify_reference(image, result, value):
     reference_match = REFERENCE_RE.fullmatch(value)
@@ -151,6 +154,11 @@ def check_labels(image, result):
     if "org.openbuildservice.disturl" not in labels:
         result.error("org.openbuildservice.disturl not set correctly, bug in OBS?")
 
+    # Reject labels like "something-%foo%" or "%foo%-something"
+    for (label_name, label_value) in labels.items():
+        if LABEL_SUB_RE.search(label_value):
+            result.error(f"Label {label_name} = {label_value} appears to be missing substitution?")
+
     # Get the image specific label prefix by looking at the .reference
     labelprefix = None
     if "org.opensuse.reference" in labels:
-- 
2.45.2

Places

File check-for-missing-substitution.patch of Package container-build-checks (Revision c837d8795e689e44040b38717f30a27c)

Places