File scons-fix_py3_syspath_explosion.patch of Package scons

Overview Repositories Revisions Requests Users Attributes Meta

File scons-fix_py3_syspath_explosion.patch of Package scons (Revision 5c92476f082d5ff92637cf5124d56c59)

Currently displaying revision 5c92476f082d5ff92637cf5124d56c59 , Show latest

From 874dba0c35cd8f6459ddbdfcdaf8be12307cd038 Mon Sep 17 00:00:00 2001
From: William Deegan <bill@baddogconsulting.com>
Date: Thu, 12 Oct 2017 23:13:49 -0400
Subject: [PATCH] Fix issue with Tool loading logic where sys.path was getting
 an addition site_scons/site_tools path prepended with every tool loaded when
 running with Python 3.5+.

---
 src/engine/SCons/Tool/__init__.py | 10 ++++++++--
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/src/engine/SCons/Tool/__init__.py b/src/engine/SCons/Tool/__init__.py
index 57090bbe..a4e44a0f 100644
--- a/src/engine/SCons/Tool/__init__.py
+++ b/src/engine/SCons/Tool/__init__.py
@@ -222,8 +222,10 @@ def _tool_module(self):
 
             # Don't reload a tool we already loaded.
             sys_modules_value = sys.modules.get(found_name,False)
+
+            found_module = None
             if sys_modules_value and sys_modules_value.__file__ == spec.origin:
-                return sys.modules[found_name]
+                found_module = sys.modules[found_name]
             else:
                 # Not sure what to do in the case that there already
                 # exists sys.modules[self.name] but the source file is
@@ -235,7 +237,11 @@ def _tool_module(self):
                     # If we found it in SCons.Tool, then add it to the module
                     setattr(SCons.Tool, self.name, module)
 
-                return module
+                found_module = module
+            
+            if found_module is not None:
+                sys.path = oldpythonpath
+                return found_module
 
 
         sys.path = oldpythonpath

Places

File scons-fix_py3_syspath_explosion.patch of Package scons (Revision 5c92476f082d5ff92637cf5124d56c59)

Places