File qt-4.5.2-fix-hwnd-64bit-casts.patch of Package mingw32-libqt4

Overview Repositories Revisions Requests Users Attributes Meta

File qt-4.5.2-fix-hwnd-64bit-casts.patch of Package mingw32-libqt4 (Revision 56aa2187a20220581559e78d580a1ec8)

Currently displaying revision 56aa2187a20220581559e78d580a1ec8 , Show latest

--- src/corelib/kernel/qcoreapplication_win.cpp.orig	2009-06-20 07:01:58.000000000 +0200
+++ src/corelib/kernel/qcoreapplication_win.cpp	2009-09-09 17:43:41.000000000 +0200
@@ -562,9 +562,12 @@
 };
 
 // Convenience function for converting flags and values into readable strings
+// Since we are going to store HWND values here, we need to use an
+// integer of the same size of a pointer.
+// Otherwise, gcc-4.4 issues a loss of precision error, which is pretty right.
 struct FLAG_STRING_STRUCT
 {
-    uint value;
+    quintptr value;
     const char* str;
 };
 
@@ -579,7 +582,7 @@
 // Returns an ORed (" | ") together string for the flags active in the actual
 // value. (...) must consist of FLAG_STRING, with a FLAG_STRING() as the last
 // value in the list passed to the function
-QString flagCheck(uint actual, ...)
+QString flagCheck(quintptr actual, ...)
 {
     va_list ap;
     va_start(ap, actual);
@@ -601,7 +604,7 @@
 // Returns the string representation of the value in 'actual'. (...) must
 // consist of FLAG_STRING, with a FLAG_STRING() as the last value in the list
 // passed to the function
-QString valueCheck(uint actual, ...)
+QString valueCheck(quintptr actual, ...)
 {
     va_list ap;
     va_start(ap, actual);
@@ -986,14 +989,14 @@
                 LPWINDOWPOS winPos = (LPWINDOWPOS)lParam;
                 if (!winPos)
                     break;
-                QString hwndAfter = valueCheck((uint)winPos->hwndInsertAfter,
-                                          FLAG_STRING((uint)HWND_BOTTOM,    "HWND_BOTTOM"),
-                                          FLAG_STRING((int)HWND_NOTOPMOST, "HWND_NOTOPMOST"),
-                                          FLAG_STRING((uint)HWND_TOP,       "HWND_TOP"),
-                                          FLAG_STRING((int)HWND_TOPMOST,   "HWND_TOPMOST"),
+                QString hwndAfter = valueCheck((quintptr)winPos->hwndInsertAfter,
+                                          FLAG_STRING((quintptr)HWND_BOTTOM,   "HWND_BOTTOM"),
+                                          FLAG_STRING((qptrdiff)HWND_NOTOPMOST, "HWND_NOTOPMOST"),
+                                          FLAG_STRING((quintptr)HWND_TOP,      "HWND_TOP"),
+                                          FLAG_STRING((qptrdiff)HWND_TOPMOST,   "HWND_TOPMOST"),
                                           FLAG_STRING());
                 if (hwndAfter.size() == 0)
-                    hwndAfter = QString::number((uint)winPos->hwndInsertAfter, 16);
+                    hwndAfter = QString::number((quintptr)winPos->hwndInsertAfter, 16);
                 QString flags = flagCheck(winPos->flags,
                                           FLGSTR(SWP_DRAWFRAME),
                                           FLGSTR(SWP_FRAMECHANGED),

Places

File qt-4.5.2-fix-hwnd-64bit-casts.patch of Package mingw32-libqt4 (Revision 56aa2187a20220581559e78d580a1ec8)

Places