File 0001-Do-not-require-network-for-test_noauth_plu... of Package python-cinderclient

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-Do-not-require-network-for-test_noauth_plugin.patch of Package python-cinderclient (Revision 47bee6a74642457f19470cdf99f8e1fe)

Currently displaying revision 47bee6a74642457f19470cdf99f8e1fe , Show latest

From d77a658a81efbb34545d442bd39a64c2f1d7625f Mon Sep 17 00:00:00 2001
From: Thomas Bechtold <tbechtold@suse.com>
Date: Tue, 30 May 2017 17:01:30 +0200
Subject: [PATCH] Do not require network for test_noauth_plugin()

While running the unittests, test_noauth_plugin() needs network access
and fails in build environments where no network is available:

keystoneauth1.exceptions.connection.ConnectFailure: Unable to establish \
  connection to http://example.com/v2/admin/volumes/detail: HTTPConnectionPool \
  (host='example.com', port=80): Max retries exceeded with url: /v2/admin/ \
  volumes/detail (Caused by NewConnectionError('<requests.packages.urllib3. \
  connection.HTTPConnection object at 0x7f04c4394290>: Failed to establish a \
  new connection: [Errno -3] Temporary failure in name resolution',))

Prevent the need of network access to be able to run the unittest in such build
envs.

Change-Id: I123919f29de7cb72a780b5f134a5bfaa404f5b53
---
 cinderclient/tests/unit/test_shell.py | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/cinderclient/tests/unit/test_shell.py b/cinderclient/tests/unit/test_shell.py
index c6557e1..728dfd4 100644
--- a/cinderclient/tests/unit/test_shell.py
+++ b/cinderclient/tests/unit/test_shell.py
@@ -169,14 +169,17 @@ class ShellTest(utils.TestCase):
             tenant_name=self.FAKE_ENV['OS_TENANT_NAME'],
             username=self.FAKE_ENV['OS_USERNAME'])
 
-    def test_noauth_plugin(self):
+    @requests_mock.Mocker()
+    def test_noauth_plugin(self, mocker):
+        os_auth_url = "http://example.com/v2"
+        mocker.register_uri('GET',
+                            "%s/admin/volumes/detail"
+                            % os_auth_url, text='{"volumes": []}')
         _shell = shell.OpenStackCinderShell()
-        args = ['--os-endpoint', 'http://example.com/v2',
+        args = ['--os-endpoint', os_auth_url,
                 '--os-auth-type', 'noauth', '--os-user-id',
                 'admin', '--os-project-id', 'admin', 'list']
-
-        # This "fails" but instantiates the client with session
-        self.assertRaises(exceptions.NotFound, _shell.main, args)
+        _shell.main(args)
         self.assertIsInstance(_shell.cs.client.session.auth,
                               noauth.CinderNoAuthPlugin)
 
-- 
2.13.0

Places

File 0001-Do-not-require-network-for-test_noauth_plugin.patch of Package python-cinderclient (Revision 47bee6a74642457f19470cdf99f8e1fe)

Places