File 0001-Fix-invalid-json-unit-test.patch of Package python-taskflow

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-Fix-invalid-json-unit-test.patch of Package python-taskflow (Revision 538e795d51636e1ec757d209e2ae6fb4)

Currently displaying revision 538e795d51636e1ec757d209e2ae6fb4 , Show latest

From 44ce6eae918d44c0ee85998d0526e916dee8de26 Mon Sep 17 00:00:00 2001
From: Ben Nemec <bnemec@redhat.com>
Date: Thu, 8 Feb 2018 16:58:42 +0000
Subject: [PATCH] Fix invalid json unit test

Recent versions of oslo.serialization have made it possible to dump
exceptions to JSON, which broke a unit test in taskflow that
assumed exceptions were unserializable.  This change switches to an
explicitly unserializable class for that test.

Change-Id: If6d19bc9fcf1f1813cb087d42dc7ba6a61c71b3d
Closes-Bug: 1748241
---
 taskflow/tests/unit/worker_based/test_protocol.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/taskflow/tests/unit/worker_based/test_protocol.py b/taskflow/tests/unit/worker_based/test_protocol.py
index 86a7e898..c253699b 100644
--- a/taskflow/tests/unit/worker_based/test_protocol.py
+++ b/taskflow/tests/unit/worker_based/test_protocol.py
@@ -25,6 +25,10 @@ from taskflow.tests import utils
 from taskflow.types import failure
 
 
+class Unserializable(object):
+    pass
+
+
 class TestProtocolValidation(test.TestCase):
     def test_send_notify(self):
         msg = pr.Notify()
@@ -166,7 +170,7 @@ class TestProtocol(test.TestCase):
         self.assertEqual(expected, request.to_dict())
 
     def test_to_dict_with_invalid_json_failures(self):
-        exc = RuntimeError(Exception("I am not valid JSON"))
+        exc = RuntimeError(Unserializable())
         a_failure = failure.Failure.from_exception(exc)
         request = self.request(failures={self.task.name: a_failure})
         expected = self.request_to_dict(
-- 
2.16.1

Places

File 0001-Fix-invalid-json-unit-test.patch of Package python-taskflow (Revision 538e795d51636e1ec757d209e2ae6fb4)

Places