File 0001-sddm-theme-lockscreen-Fix-login-button-siz... of Package plasma5-workspace

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-sddm-theme-lockscreen-Fix-login-button-size.patch of Package plasma5-workspace (Revision fc8c6c00f55a8e84f2d3c83457a603fa)

Currently displaying revision fc8c6c00f55a8e84f2d3c83457a603fa , Show latest

From 2f9129410401c2d734aff1602b37be70cebbb74b Mon Sep 17 00:00:00 2001
From: Noah Davis <noahadvs@gmail.com>
Date: Mon, 14 Sep 2020 10:18:57 -0400
Subject: [PATCH] [sddm-theme/lockscreen] Fix login button size

Some users reported this button becoming too small after KF5.74 was released, but I could not reproduce it myself. However, this code did look suspicious. Hopefully this fixes the issue.

(cherry picked from commit 9a8fc811282e303ec2f93c978228a85961dae263)
---
 lookandfeel/contents/lockscreen/MainBlock.qml | 3 ++-
 sddm-theme/Login.qml                          | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/lookandfeel/contents/lockscreen/MainBlock.qml b/lookandfeel/contents/lockscreen/MainBlock.qml
index 4bd5df0e5..70b43d959 100644
--- a/lookandfeel/contents/lockscreen/MainBlock.qml
+++ b/lookandfeel/contents/lockscreen/MainBlock.qml
@@ -97,7 +97,8 @@ SessionManagementScreen {
         PlasmaComponents.Button {
             id: loginButton
             Accessible.name: i18nd("plasma_lookandfeel_org.kde.lookandfeel", "Unlock")
-            implicitHeight: passwordBox.height - units.smallSpacing * 0.5 // otherwise it comes out taller than the password field
+            Layout.preferredHeight: passwordBox.implicitHeight
+            Layout.preferredWidth: loginButton.Layout.preferredHeight
 
             PlasmaCore.IconItem { // no iconSource because if you take away half a unit (implicitHeight), "go-next" gets cut off
                     anchors.fill: parent
diff --git a/sddm-theme/Login.qml b/sddm-theme/Login.qml
index 49d6805d8..3daaebf57 100644
--- a/sddm-theme/Login.qml
+++ b/sddm-theme/Login.qml
@@ -112,8 +112,8 @@ SessionManagementScreen {
         PlasmaComponents.Button {
             id: loginButton
             Accessible.name: i18nd("plasma_lookandfeel_org.kde.lookandfeel", "Log In")
-            implicitHeight: passwordBox.height - units.smallSpacing * 0.5 // otherwise it comes out taller than the password field
-            Layout.rightMargin: 1 // prevents it from extending beyond the username field
+            Layout.preferredHeight: passwordBox.implicitHeight
+            Layout.preferredWidth: loginButton.Layout.preferredHeight
 
             PlasmaCore.IconItem { // no iconSource because if you take away half a unit (implicitHeight), "go-next" gets cut off
                 anchors.fill: parent
-- 
2.25.1

Places

File 0001-sddm-theme-lockscreen-Fix-login-button-size.patch of Package plasma5-workspace (Revision fc8c6c00f55a8e84f2d3c83457a603fa)

Places